Changeset 207245 in webkit


Ignore:
Timestamp:
Oct 12, 2016 2:50:03 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

[Modern Media Controls] Sliders: scrubber and volume
​https://bugs.webkit.org/show_bug.cgi?id=163328
<rdar://problem/28733838>

Patch by Antoine Quint <Antoine Quint> on 2016-10-12
Reviewed by Dean Jackson.

Source/WebCore:

We add a new Slider class that provides a custom slider backed by an
invisible <input type="range"> element and a fill underlay to provide
a custom color between the left edge of the slider and the slider thumb.
As the slider's value changes, a UI delegate receives messages to track
such changes.

Tests: media/modern-media-controls/scrubber/scrubber.html

media/modern-media-controls/slider/slider-constructor.html
media/modern-media-controls/slider/slider-fill.html
media/modern-media-controls/slider/slider-styles.html
media/modern-media-controls/volume-slider/volume-slider-value.html
media/modern-media-controls/volume-slider/volume-slider.html

  • Modules/modern-media-controls/controls/scrubber.css: Added.

(.scrubber.slider > input::-webkit-slider-thumb):

  • Modules/modern-media-controls/controls/scrubber.js: Added.

(Scrubber):

  • Modules/modern-media-controls/controls/slider.css: Added.

(.slider):
(.slider > input,):
(.slider > .fill):
(.slider > input):
(.slider > input::-webkit-slider-thumb):

  • Modules/modern-media-controls/controls/slider.js: Added.

(Slider.prototype.get value):
(Slider.prototype.set value):
(Slider.prototype.get width):
(Slider.prototype.set width):
(Slider.prototype.handleEvent):
(Slider.prototype.commitProperty):
(Slider.prototype._handleInputEvent):
(Slider.prototype._handleChangeEvent):
(Slider.prototype._updateFill):

  • Modules/modern-media-controls/controls/volume-slider.css: Added.

(.volume.slider > input::-webkit-slider-thumb):

  • Modules/modern-media-controls/controls/volume-slider.js: Added.

(VolumeSlider):

LayoutTests:

Testing the properties of the new Slider class and its subclasses.

  • media/modern-media-controls/resources/media-controls-utils.js: Added.

(rgba):
(shouldBeEqualToRGBAColor):

  • media/modern-media-controls/scrubber/scrubber-expected.txt: Added.
  • media/modern-media-controls/scrubber/scrubber.html: Added.
  • media/modern-media-controls/slider/slider-constructor-expected.txt: Added.
  • media/modern-media-controls/slider/slider-constructor.html: Added.
  • media/modern-media-controls/slider/slider-fill-expected.txt: Added.
  • media/modern-media-controls/slider/slider-fill.html: Added.
  • media/modern-media-controls/slider/slider-styles-expected.txt: Added.
  • media/modern-media-controls/slider/slider-styles.html: Added.
  • media/modern-media-controls/volume-slider/volume-slider-expected.txt: Added.
  • media/modern-media-controls/volume-slider/volume-slider-value-expected.txt: Added.
  • media/modern-media-controls/volume-slider/volume-slider-value.html: Added.
  • media/modern-media-controls/volume-slider/volume-slider.html: Added.
  • platform/ios-simulator/TestExpectations:
Location:
trunk
Files:
23 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r207244 r207245  
     12016-10-12  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Sliders: scrubber and volume
     4        https://bugs.webkit.org/show_bug.cgi?id=163328
     5        <rdar://problem/28733838>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Testing the properties of the new Slider class and its subclasses.
     10
     11        * media/modern-media-controls/resources/media-controls-utils.js: Added.
     12        (rgba):
     13        (shouldBeEqualToRGBAColor):
     14        * media/modern-media-controls/scrubber/scrubber-expected.txt: Added.
     15        * media/modern-media-controls/scrubber/scrubber.html: Added.
     16        * media/modern-media-controls/slider/slider-constructor-expected.txt: Added.
     17        * media/modern-media-controls/slider/slider-constructor.html: Added.
     18        * media/modern-media-controls/slider/slider-fill-expected.txt: Added.
     19        * media/modern-media-controls/slider/slider-fill.html: Added.
     20        * media/modern-media-controls/slider/slider-styles-expected.txt: Added.
     21        * media/modern-media-controls/slider/slider-styles.html: Added.
     22        * media/modern-media-controls/volume-slider/volume-slider-expected.txt: Added.
     23        * media/modern-media-controls/volume-slider/volume-slider-value-expected.txt: Added.
     24        * media/modern-media-controls/volume-slider/volume-slider-value.html: Added.
     25        * media/modern-media-controls/volume-slider/volume-slider.html: Added.
     26        * platform/ios-simulator/TestExpectations:
     27
    1282016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
    229

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r207244 r207245  
    26882688
    26892689webkit.org/b/163009 media/modern-media-controls/icon-button/icon-button-active-state.html [ Failure ]
     2690webkit.org/b/163357 media/modern-media-controls/volume-slider/volume-slider-value.html [ Skip ]
    26902691
    26912692# This variation font test requires Skia which isn't available on iOS.

  • trunk/Source/WebCore/ChangeLog

    r207244 r207245  
     12016-10-12  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Sliders: scrubber and volume
     4        https://bugs.webkit.org/show_bug.cgi?id=163328
     5        <rdar://problem/28733838>
     6
     7        Reviewed by Dean Jackson.
     8
     9        We add a new Slider class that provides a custom slider backed by an
     10        invisible <input type="range"> element and a fill underlay to provide
     11        a custom color between the left edge of the slider and the slider thumb.
     12        As the slider's value changes, a UI delegate receives messages to track
     13        such changes.
     14
     15        Tests: media/modern-media-controls/scrubber/scrubber.html
     16               media/modern-media-controls/slider/slider-constructor.html
     17               media/modern-media-controls/slider/slider-fill.html
     18               media/modern-media-controls/slider/slider-styles.html
     19               media/modern-media-controls/volume-slider/volume-slider-value.html
     20               media/modern-media-controls/volume-slider/volume-slider.html
     21
     22        * Modules/modern-media-controls/controls/scrubber.css: Added.
     23        (.scrubber.slider > input::-webkit-slider-thumb):
     24        * Modules/modern-media-controls/controls/scrubber.js: Added.
     25        (Scrubber):
     26        * Modules/modern-media-controls/controls/slider.css: Added.
     27        (.slider):
     28        (.slider > input,):
     29        (.slider > .fill):
     30        (.slider > input):
     31        (.slider > input::-webkit-slider-thumb):
     32        * Modules/modern-media-controls/controls/slider.js: Added.
     33        (Slider.prototype.get value):
     34        (Slider.prototype.set value):
     35        (Slider.prototype.get width):
     36        (Slider.prototype.set width):
     37        (Slider.prototype.handleEvent):
     38        (Slider.prototype.commitProperty):
     39        (Slider.prototype._handleInputEvent):
     40        (Slider.prototype._handleChangeEvent):
     41        (Slider.prototype._updateFill):
     42        * Modules/modern-media-controls/controls/volume-slider.css: Added.
     43        (.volume.slider > input::-webkit-slider-thumb):
     44        * Modules/modern-media-controls/controls/volume-slider.js: Added.
     45        (VolumeSlider):
     46
    1472016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
    248
Note: See TracChangeset for help on using the changeset viewer.