Changeset 207351 in webkit


Ignore:
Timestamp:
Oct 14, 2016 11:29:16 AM (7 years ago)
Author:
Michael Catanzaro
Message:

[CMake] Private/unsupported build options should be marked as advanced
https://bugs.webkit.org/show_bug.cgi?id=163451

Reviewed by Carlos Garcia Campos.

When checking to decide whether to mark an option as advanced, the conditional checks
whether _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} is defined. It is always defined. We
need to check its value instead.

  • Source/cmake/WebKitFeatures.cmake:
Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r207311 r207351  
     12016-10-14  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        [CMake] Private/unsupported build options should be marked as advanced
     4        https://bugs.webkit.org/show_bug.cgi?id=163451
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        When checking to decide whether to mark an option as advanced, the conditional checks
     9        whether _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} is defined. It is always defined. We
     10        need to check its value instead.
     11
     12        * Source/cmake/WebKitFeatures.cmake:
     13
    1142016-10-13  Brian Burg  <bburg@apple.com>
    215
  • trunk/Source/cmake/WebKitFeatures.cmake

    r207279 r207351  
    269269
    270270        option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}})
    271         if (NOT _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name})
     271        if (NOT ${_WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name}})
    272272            mark_as_advanced(FORCE ${_name})
    273273        endif ()
Note: See TracChangeset for help on using the changeset viewer.