Changeset 207368 in webkit

Timestamp:

Oct 14, 2016 6:48:36 PM (8 years ago)

Author:

Chris Dumez

Message:

Setting HTMLMediaElement.muted to the same value should not fire a volume change event
​https://bugs.webkit.org/show_bug.cgi?id=163474

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

• web-platform-tests/html/semantics/embedded-content/media-elements/event_volumechange-expected.txt:

Source/WebCore:

Setting HTMLMediaElement.muted to the same value should not fire a volume
change event:

• ​https://html.spec.whatwg.org/#dom-media-muted

Chrome and Firefox agree with the specification.

No new tests, rebaselined existing test.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMuted):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_volumechange-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLMediaElement.cpp (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-10-14  Chris Dumez  <cdumez@apple.com>
+
+        Setting HTMLMediaElement.muted to the same value should not fire a volume change event
+        https://bugs.webkit.org/show_bug.cgi?id=163474
+
+        Reviewed by Eric Carlson.
+
+        Rebaseline W3C test now that more checks are passing.
+
+        * web-platform-tests/html/semantics/embedded-content/media-elements/event_volumechange-expected.txt:
+
 2016-10-14  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_volumechange-expected.txt

@@ -2 +2 @@
 PASS setting audio.volume fires volumechange 
 PASS setting audio.muted fires volumechange 
-FAIL setting audio.volume/muted to the same value does not fire volumechange assert_unreached: Reached unreachable code
+PASS setting audio.volume/muted to the same value does not fire volumechange 
 PASS setting audio.volume/muted repeatedly fires volumechange repeatedly 
 PASS setting video.volume fires volumechange 
 PASS setting video.muted fires volumechange 
-FAIL setting video.volume/muted to the same value does not fire volumechange assert_unreached: Reached unreachable code
+PASS setting video.volume/muted to the same value does not fire volumechange 
 PASS setting video.volume/muted repeatedly fires volumechange repeatedly 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-14  Chris Dumez  <cdumez@apple.com>
+
+        Setting HTMLMediaElement.muted to the same value should not fire a volume change event
+        https://bugs.webkit.org/show_bug.cgi?id=163474
+
+        Reviewed by Eric Carlson.
+
+        Setting HTMLMediaElement.muted to the same value should not fire a volume
+        change event:
+        - https://html.spec.whatwg.org/#dom-media-muted
+
+        Chrome and Firefox agree with the specification.
+
+        No new tests, rebaselined existing test.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::setMuted):
+
 2016-10-14  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -3303 +3303 @@
     LOG(Media, "HTMLMediaElement::setMuted(%p) - %s", this, boolString(muted));
 
-    if (m_muted != muted || !m_explicitlyMuted) {
+    bool mutedStateChanged = m_muted != muted;
+    if (mutedStateChanged || !m_explicitlyMuted) {
         m_muted = muted;
         m_explicitlyMuted = true;
@@ -3318 +3319 @@
             }
         }
-        scheduleEvent(eventNames().volumechangeEvent);
+
+        if (mutedStateChanged)
+            scheduleEvent(eventNames().volumechangeEvent);
 
         updateShouldPlay();