Changeset 207412 in webkit


Ignore:
Timestamp:
Oct 17, 2016 10:32:18 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

preprocessor.pm: cl.exe outputs processing filenames if Windows Perl is used
https://bugs.webkit.org/show_bug.cgi?id=163435

Patch by Fujii Hironori <Fujii Hironori> on 2016-10-17
Reviewed by Alex Christensen.

cl.exe outputs processing filenames to stderr. Suppress this
annoying messages by using open3 instead of open2.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): Use open3 in case of Windows Perl.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r207411 r207412  
     12016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        preprocessor.pm: cl.exe outputs processing filenames if Windows Perl is used
     4        https://bugs.webkit.org/show_bug.cgi?id=163435
     5
     6        Reviewed by Alex Christensen.
     7
     8        cl.exe outputs processing filenames to stderr. Suppress this
     9        annoying messages by using open3 instead of open2.
     10
     11        * bindings/scripts/preprocessor.pm:
     12        (applyPreprocessor): Use open3 in case of Windows Perl.
     13
    1142016-10-17  Mark Lam  <mark.lam@apple.com>
    215
  • trunk/Source/WebCore/bindings/scripts/preprocessor.pm

    r195582 r207412  
    100100        };
    101101    } elsif ($Config::Config{"osname"} eq "MSWin32") {
    102         $pid = open2(\*PP_OUT, \*PP_IN, $preprocessor, @args, @macros, $fileName);
     102        # Suppress STDERR so that if we're using cl.exe, the output
     103        # name isn't needlessly echoed.
     104        use Symbol 'gensym'; my $err = gensym;
     105        $pid = open3(\*PP_IN, \*PP_OUT, $err, $preprocessor, @args, @macros, $fileName);
    103106    } else {
    104107        $pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), @args, @macros, $fileName);
Note: See TracChangeset for help on using the changeset viewer.