Changeset 207477 in webkit

Timestamp:

Oct 18, 2016, 12:19:45 PM (10 years ago)

Author:

Brent Fulgham

Message:

Correct Document::removeAllEventListeners
​https://bugs.webkit.org/show_bug.cgi?id=163558
<rdar://problem/28716840>

Reviewed by Chris Dumez.

Tested by fast/dom/node-move-to-new-document-crash-main.html.

• dom/Document.cpp:

(WebCore::Document::removeAllEventListeners): Clear out the wheel and
touch event targets when clearing all data.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-18  Brent Fulgham  <bfulgham@apple.com>
+
+        Correct Document::removeAllEventListeners
+        https://bugs.webkit.org/show_bug.cgi?id=163558
+        <rdar://problem/28716840>
+
+        Reviewed by Chris Dumez.
+
+        Tested by fast/dom/node-move-to-new-document-crash-main.html.
+
+        * dom/Document.cpp:
+        (WebCore::Document::removeAllEventListeners): Clear out the wheel and
+        touch event targets when clearing all data.
+
 2016-10-18  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -2352 +2352 @@
     for (Node* node = firstChild(); node; node = NodeTraversal::next(*node))
         node->removeAllEventListeners();
+
+#if ENABLE(TOUCH_EVENTS)
+    m_touchEventTargets = nullptr;
+#endif
+    m_wheelEventTargets = nullptr;
 }