Changeset 207486 in webkit

Timestamp:

Oct 18, 2016 1:40:03 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION (r201471): Keyboard remains visible when swiping back on twitter.com
​https://bugs.webkit.org/show_bug.cgi?id=163581
<rdar://problem/27739558>

Reviewed by Simon Fraser.

Source/WebCore:

The bug was caused by Chrome::elementDidBlur not getting called, which resulted in
StopAssistingNode not getting sent to the UI process.

Test: fast/forms/ios/hide-keyboard-on-node-removal.html

• dom/Document.cpp:

(WebCore::Document::setFocusedElement): Restore the behavior prior to r201471 by calling
Chrome::elementDidBlur explicitly.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchBlurEvent): Added a comment about ordering.

LayoutTests:

Added a regression test for hiding a keyboard when the focused element is removed from the DOM.

• fast/forms/ios/hide-keyboard-on-node-removal-expected.txt: Added.
• fast/forms/ios/hide-keyboard-on-node-removal.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/ios/hide-keyboard-on-node-removal-expected.txt (added)
• LayoutTests/fast/forms/ios/hide-keyboard-on-node-removal.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)
• Source/WebCore/html/HTMLTextFormControlElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-10-18  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION (r201471): Keyboard remains visible when swiping back on twitter.com
+        https://bugs.webkit.org/show_bug.cgi?id=163581
+        <rdar://problem/27739558>
+
+        Reviewed by Simon Fraser.
+
+        Added a regression test for hiding a keyboard when the focused element is removed from the DOM.
+
+        * fast/forms/ios/hide-keyboard-on-node-removal-expected.txt: Added.
+        * fast/forms/ios/hide-keyboard-on-node-removal.html: Added.
+
 2016-10-18  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-18  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION (r201471): Keyboard remains visible when swiping back on twitter.com
+        https://bugs.webkit.org/show_bug.cgi?id=163581
+        <rdar://problem/27739558>
+
+        Reviewed by Simon Fraser.
+
+        The bug was caused by Chrome::elementDidBlur not getting called, which resulted in
+        StopAssistingNode not getting sent to the UI process.
+
+        Test: fast/forms/ios/hide-keyboard-on-node-removal.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::setFocusedElement): Restore the behavior prior to r201471 by calling
+        Chrome::elementDidBlur explicitly.
+        * html/HTMLTextFormControlElement.cpp:
+        (WebCore::HTMLTextFormControlElement::dispatchBlurEvent): Added a comment about ordering.
+
 2016-10-17  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -3675 +3675 @@
             }
         } else {
+            // Match the order in HTMLTextFormControlElement::dispatchBlurEvent.
             if (is<HTMLInputElement>(*oldFocusedElement))
                 downcast<HTMLInputElement>(*oldFocusedElement).endEditing();
+            if (page())
+                page()->chrome().client().elementDidBlur(oldFocusedElement.get());
             ASSERT(!m_focusedElement);
         }

trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp

@@ -102 +102 @@
     if (supportsPlaceholder())
         updatePlaceholderVisibility();
+    // Match the order in Document::setFocusedElement.
     handleBlurEvent();
     HTMLFormControlElementWithState::dispatchBlurEvent(WTFMove(newFocusedElement));