Changeset 209186 in webkit


Ignore:
Timestamp:
Dec 1, 2016 10:38:51 AM (7 years ago)
Author:
graouts@webkit.org
Message:

[Modern Media Controls] Fix media/modern-media-controls/status-label/status-label.html
​https://bugs.webkit.org/show_bug.cgi?id=165259

Reviewed by Dean Jackson.

We broke the test at media/modern-media-controls/status-label/status-label.html with the
fix for ​https://bugs.webkit.org/show_bug.cgi?id=165239 since the test would test the
font-family for a StatusLabel which would only inherited to be -apple-system when hosted
in a MediaControls instance. We now remove this assertion and added a dedicated test
for when a StatusLabel is hosted in a MediaControls.

  • media/modern-media-controls/status-label/status-label-expected.txt:
  • media/modern-media-controls/status-label/status-label-font-expected.txt: Added.
  • media/modern-media-controls/status-label/status-label-font.html: Added.
  • media/modern-media-controls/status-label/status-label.html:
Location:
trunk/LayoutTests
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r209185 r209186  
     12016-12-01  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Fix media/modern-media-controls/status-label/status-label.html
     4        https://bugs.webkit.org/show_bug.cgi?id=165259
     5
     6        Reviewed by Dean Jackson.
     7
     8        We broke the test at media/modern-media-controls/status-label/status-label.html with the
     9        fix for https://bugs.webkit.org/show_bug.cgi?id=165239 since the test would test the
     10        font-family for a StatusLabel which would only inherited to be -apple-system when hosted
     11        in a MediaControls instance. We now remove this assertion and added a dedicated test
     12        for when a StatusLabel is hosted in a MediaControls.
     13
     14        * media/modern-media-controls/status-label/status-label-expected.txt:
     15        * media/modern-media-controls/status-label/status-label-font-expected.txt: Added.
     16        * media/modern-media-controls/status-label/status-label-font.html: Added.
     17        * media/modern-media-controls/status-label/status-label.html:
     18
    1192016-12-01  Ryan Haddad  <ryanhaddad@apple.com>
    220

  • trunk/LayoutTests/media/modern-media-controls/status-label/status-label-expected.txt

    r208456 r209186  
    1919PASS style.whiteSpace is "nowrap"
    2020PASS style.overflow is "hidden"
    21 PASS style.fontFamily is "-apple-system"
    2221PASS style.fontSize is "14px"
    2322PASS rgba(style.color).r is 255

  • trunk/LayoutTests/media/modern-media-controls/status-label/status-label.html

    r208456 r209186  
    4040    shouldBeEqualToString("style.whiteSpace", "nowrap");
    4141    shouldBeEqualToString("style.overflow", "hidden");
    42     shouldBeEqualToString("style.fontFamily", "-apple-system");
    4342    shouldBeEqualToString("style.fontSize", "14px");
    4443    shouldBeEqualToRGBAColor("style.color", "rgba(255, 255, 255, 0.572)");
Note: See TracChangeset for help on using the changeset viewer.