Changeset 209193 in webkit
- Timestamp:
- Dec 1, 2016 12:33:05 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r209191 r209193 1 2016-12-01 Chris Dumez <cdumez@apple.com> 2 3 Parameter to DOMStringList.contains() should be mandatory 4 https://bugs.webkit.org/show_bug.cgi?id=165257 5 6 Reviewed by Alex Christensen. 7 8 Extend layout test coverage. 9 10 * storage/indexeddb/database-basics-expected.txt: 11 * storage/indexeddb/resources/database-basics.js: 12 (checkObjectStore): 13 1 14 2016-12-01 Jiewen Tan <jiewen_tan@apple.com> 2 15 -
trunk/LayoutTests/storage/indexeddb/database-basics-expected.txt
r195181 r209193 27 27 PASS db.objectStoreNames.contains('test456') is false 28 28 PASS db.objectStoreNames.contains('test123') is true 29 PASS db.objectStoreNames.contains() threw exception TypeError: Not enough arguments. 29 30 db.close() 30 31 request = indexedDB.open(dbname, 2) … … 37 38 PASS db.objectStoreNames.contains('test456') is false 38 39 PASS db.objectStoreNames.contains('test123') is true 40 PASS db.objectStoreNames.contains() threw exception TypeError: Not enough arguments. 39 41 db.createObjectStore("test456") 40 42 setVersionTrans = event.target.transaction … … 47 49 PASS db.objectStoreNames.contains('test456') is false 48 50 PASS db.objectStoreNames.contains('test123') is true 51 PASS db.objectStoreNames.contains() threw exception TypeError: Not enough arguments. 49 52 db.close() 50 53 Now that the connection is closed, transaction creation should fail -
trunk/LayoutTests/storage/indexeddb/database-basics-private-expected.txt
r195247 r209193 27 27 PASS db.objectStoreNames.contains('test456') is false 28 28 PASS db.objectStoreNames.contains('test123') is true 29 PASS db.objectStoreNames.contains() threw exception TypeError: Not enough arguments. 29 30 db.close() 30 31 request = indexedDB.open(dbname, 2) … … 37 38 PASS db.objectStoreNames.contains('test456') is false 38 39 PASS db.objectStoreNames.contains('test123') is true 40 PASS db.objectStoreNames.contains() threw exception TypeError: Not enough arguments. 39 41 db.createObjectStore("test456") 40 42 setVersionTrans = event.target.transaction … … 47 49 PASS db.objectStoreNames.contains('test456') is false 48 50 PASS db.objectStoreNames.contains('test123') is true 51 PASS db.objectStoreNames.contains() threw exception TypeError: Not enough arguments. 49 52 db.close() 50 53 Now that the connection is closed, transaction creation should fail -
trunk/LayoutTests/storage/indexeddb/resources/database-basics.js
r163963 r209193 33 33 shouldBe("db.objectStoreNames.contains('test456')", "false"); 34 34 shouldBe("db.objectStoreNames.contains('test123')", "true"); 35 shouldThrow("db.objectStoreNames.contains()"); 35 36 } 36 37 -
trunk/Source/WebCore/ChangeLog
r209191 r209193 1 2016-12-01 Chris Dumez <cdumez@apple.com> 2 3 Parameter to DOMStringList.contains() should be mandatory 4 https://bugs.webkit.org/show_bug.cgi?id=165257 5 6 Reviewed by Alex Christensen. 7 8 Parameter to DOMStringList.contains() should be mandatory. 9 Gecko and Blink have it mandatory but WebKit had it optional and the 10 string 'undefined" was used by default, which is not helpful. 11 12 No new tests, updated existing test. 13 14 * dom/DOMStringList.idl: 15 1 16 2016-12-01 Jiewen Tan <jiewen_tan@apple.com> 2 17 -
trunk/Source/WebCore/dom/DOMStringList.idl
r204679 r209193 30 30 getter DOMString? item(unsigned long index); 31 31 32 // FIXME: Using "undefined" as default parameter value is wrong. 33 boolean contains(optional DOMString string = "undefined"); 32 boolean contains(DOMString string); 34 33 }; 35 34
Note: See TracChangeset
for help on using the changeset viewer.