Changeset 209232 in webkit

Timestamp:

Dec 1, 2016 10:08:30 PM (7 years ago)

Author:

BJ Burg

Message:

Remote Inspector: fix weird typo in generated ObjC protocol type initializer implementations
​https://bugs.webkit.org/show_bug.cgi?id=165295
<rdar://problem/29427778>

Reviewed by Joseph Pecoraro.

Remove a stray semicolon appended after custom initializer signatures.
This is a syntax error when building with less lenient compiler warnings.

• inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:

(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_required_members):

• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/scripts/codegen/generate_objc_protocol_types_implementation.py (modified) (1 diff)
• inspector/scripts/tests/expected/commands-with-async-attribute.json-result (modified) (1 diff)
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result (modified) (1 diff)
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result (modified) (1 diff)
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result (modified) (1 diff)
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result (modified) (1 diff)
• inspector/scripts/tests/expected/type-declaration-object-type.json-result (modified) (4 diffs)
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-12-01  Brian Burg  <bburg@apple.com>
+
+        Remote Inspector: fix weird typo in generated ObjC protocol type initializer implementations
+        https://bugs.webkit.org/show_bug.cgi?id=165295
+        <rdar://problem/29427778>
+
+        Reviewed by Joseph Pecoraro.
+
+        Remove a stray semicolon appended after custom initializer signatures.
+        This is a syntax error when building with less lenient compiler warnings.
+
+        * inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
+        (ObjCProtocolTypesImplementationGenerator._generate_init_method_for_required_members):
+        * inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
+        * inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
+        * inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
+        * inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
+        * inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
+        * inspector/scripts/tests/expected/type-declaration-object-type.json-result:
+        * inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
+
 2016-12-01  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py

@@ -148 +148 @@
         pairs[0] = ucfirst(pairs[0])
         lines = []
-        lines.append('- (instancetype)initWith%s;' % ' '.join(pairs))
+        lines.append('- (instancetype)initWith%s' % ' '.join(pairs))
         lines.append('{')
         lines.append('    if (!(self = [super init]))')

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result

@@ -1716 +1716 @@
 }
 
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
 {
     if (!(self = [super init]))

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result

@@ -1571 +1571 @@
 }
 
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
 {
     if (!(self = [super init]))

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result

@@ -1145 +1145 @@
 }
 
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
 {
     if (!(self = [super init]))

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result

@@ -1191 +1191 @@
 }
 
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
 {
     if (!(self = [super init]))

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result

@@ -1048 +1048 @@
 }
 
-- (instancetype)initWithType:(TestProtocolRuntimeKeyPathType)type;
+- (instancetype)initWithType:(TestProtocolRuntimeKeyPathType)type
 {
     if (!(self = [super init]))

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result

@@ -1474 +1474 @@
 }
 
-- (instancetype)initWithMessage:(NSString *)message code:(int)code;
+- (instancetype)initWithMessage:(NSString *)message code:(int)code
 {
     if (!(self = [super init]))
@@ -1651 +1651 @@
 }
 
-- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error errorList:(NSArray/*<TestProtocolDatabaseError>*/ *)errorList;
+- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error errorList:(NSArray/*<TestProtocolDatabaseError>*/ *)errorList
 {
     if (!(self = [super init]))
@@ -1780 +1780 @@
 }
 
-- (instancetype)initWithInteger:(NSString *)integer array:(NSString *)array string:(NSString *)string value:(NSString *)value object:(NSString *)object;
+- (instancetype)initWithInteger:(NSString *)integer array:(NSString *)array string:(NSString *)string value:(NSString *)value object:(NSString *)object
 {
     if (!(self = [super init]))
@@ -1907 +1907 @@
 }
 
-- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error;
+- (instancetype)initWithColumnNames:(NSArray/*<NSString>*/ *)columnNames notes:(NSString *)notes timestamp:(double)timestamp values:(RWIProtocolJSONObject *)values payload:(RWIProtocolJSONObject *)payload error:(TestProtocolDatabaseError *)error
 {
     if (!(self = [super init]))

trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result

@@ -1454 +1454 @@
 }
 
-- (instancetype)initWithString:(NSString *)string number:(int)number animals:(TestProtocolTestCastedAnimals)animals identifier:(int)identifier tree:(TestProtocolTestRecursiveObject1 *)tree;
+- (instancetype)initWithString:(NSString *)string number:(int)number animals:(TestProtocolTestCastedAnimals)animals identifier:(int)identifier tree:(TestProtocolTestRecursiveObject1 *)tree
 {
     if (!(self = [super init]))