Changeset 210498 in webkit

Timestamp:

Jan 8, 2017 9:35:14 PM (7 years ago)

Author:

akling@apple.com

Message:

Inject MarkedSpace size classes for a few more high-volume objects.
<​https://webkit.org/b/166815>

Reviewed by Darin Adler.

Add the following classes to the list of manually injected size classes:

• JSString
• JSFunction
• PropertyTable
• Structure

Only Structure actually ends up with a new size class, the others already
can't get any tighter due to the current MarkedBlock::atomSize being 16.
I've put them in anyway to ensure that we have optimally carved-out cells
for them in the future, should they grow.

With this change, Structures get allocated in 128-byte cells instead of
160-byte cells, giving us 25% more Structures per MarkedBlock.

• heap/MarkedSpace.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/MarkedSpace.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-01-08  Andreas Kling  <akling@apple.com>
+
+        Inject MarkedSpace size classes for a few more high-volume objects.
+        <https://webkit.org/b/166815>
+
+        Reviewed by Darin Adler.
+
+        Add the following classes to the list of manually injected size classes:
+
+            - JSString
+            - JSFunction
+            - PropertyTable
+            - Structure
+
+        Only Structure actually ends up with a new size class, the others already
+        can't get any tighter due to the current MarkedBlock::atomSize being 16.
+        I've put them in anyway to ensure that we have optimally carved-out cells
+        for them in the future, should they grow.
+
+        With this change, Structures get allocated in 128-byte cells instead of
+        160-byte cells, giving us 25% more Structures per MarkedBlock.
+
+        * heap/MarkedSpace.cpp:
+
 2017-01-06  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/heap/MarkedSpace.cpp

@@ -131 +131 @@
             }
 
+            // Manually inject size classes for objects we know will be allocated in high volume.
             add(sizeof(UnlinkedFunctionExecutable));
             add(sizeof(UnlinkedFunctionCodeBlock));
             add(sizeof(FunctionExecutable));
             add(sizeof(FunctionCodeBlock));
+            add(sizeof(JSString));
+            add(sizeof(JSFunction));
+            add(sizeof(PropertyTable));
+            add(sizeof(Structure));
 
             {