⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 210882 in webkit


Ignore:
Timestamp:
Jan 18, 2017, 1:35:30 PM (10 years ago)
Author:
mmaxfield@apple.com
Message:

background-repeat-x doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=166997

Reviewed by Simon Fraser.

Source/WebCore:

During the creation of the new CSS parser, we accidentally forgot
to hook up background-repeat-x and background-repeat-y.

Tests: fast/backgrounds/background-repeat-x-y-parse.html

fast/backgrounds/background-repeat-x-y.html

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isKeywordPropertyID):

LayoutTests:

  • fast/backgrounds/background-repeat-x-y-expected.html: Added.
  • fast/backgrounds/background-repeat-x-y-parse-expected.txt: Added.
  • fast/backgrounds/background-repeat-x-y-parse.html: Added.
  • fast/backgrounds/background-repeat-x-y.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r210881 r210882  
     12017-01-18  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        background-repeat-x doesn't work
     4        https://bugs.webkit.org/show_bug.cgi?id=166997
     5
     6        Reviewed by Simon Fraser.
     7
     8        * fast/backgrounds/background-repeat-x-y-expected.html: Added.
     9        * fast/backgrounds/background-repeat-x-y-parse-expected.txt: Added.
     10        * fast/backgrounds/background-repeat-x-y-parse.html: Added.
     11        * fast/backgrounds/background-repeat-x-y.html: Added.
     12
    1132017-01-18  Yoav Weiss  <yoav@yoav.ws>
    214

  • trunk/Source/WebCore/ChangeLog

    r210864 r210882  
     12017-01-18  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        background-repeat-x doesn't work
     4        https://bugs.webkit.org/show_bug.cgi?id=166997
     5
     6        Reviewed by Simon Fraser.
     7
     8        During the creation of the new CSS parser, we accidentally forgot
     9        to hook up background-repeat-x and background-repeat-y.
     10
     11        Tests: fast/backgrounds/background-repeat-x-y-parse.html
     12               fast/backgrounds/background-repeat-x-y.html
     13
     14        * css/parser/CSSParserFastPaths.cpp:
     15        (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     16
    1172017-01-18  Andy Estes  <aestes@apple.com>
    218

  • trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp

    r210024 r210882  
    931931    // case CSSPropertyAll:
    932932
    933     // FIXME-NEWPARSER: Treat the following properties as keyword properties:
    934     // case CSSPropertyBackgroundRepeatX:
    935     // case CSSPropertyBackgroundRepeatY:
     933    case CSSPropertyBackgroundRepeatX:
     934    case CSSPropertyBackgroundRepeatY:
    936935
    937936    // FIXME-NEWPARSER: Add the following unprefixed properties:
Note: See TracChangeset for help on using the changeset viewer.