Changeset 211052 in webkit

Timestamp:

Jan 23, 2017, 12:58:35 PM (10 years ago)

Author:

andersca@apple.com

Message:

When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
​https://bugs.webkit.org/show_bug.cgi?id=167268
rdar://problem/29857388

Reviewed by Sam Weinig.

Source/WebCore:

• page/Page.cpp:

(WebCore::Page::refreshPlugins):
Call PluginInfoProvider::refresh instead.

(WebCore::Page::clearPluginData):
Add new setter.

• page/Page.h:

Declare new members.

• plugins/PluginInfoProvider.cpp:

(WebCore::PluginInfoProvider::refresh):
Put the logic to clear plug-in data and reload frames here.

• plugins/PluginInfoProvider.h:

Add new members.

Source/WebKit2:

• WebProcess/Plugins/WebPluginInfoProvider.h:

Make refreshPlugins() private.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::refreshPlugins):
Call the newly added PluginInfoProvider::refresh().

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Page.cpp (modified) (2 diffs)
• WebCore/page/Page.h (modified) (1 diff)
• WebCore/plugins/PluginInfoProvider.cpp (modified) (2 diffs)
• WebCore/plugins/PluginInfoProvider.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h (modified) (2 diffs)
• WebKit2/WebProcess/WebProcess.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-20  Anders Carlsson  <andersca@apple.com>
+
+        When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
+        https://bugs.webkit.org/show_bug.cgi?id=167268
+        rdar://problem/29857388
+
+        Reviewed by Sam Weinig.
+
+        * page/Page.cpp:
+        (WebCore::Page::refreshPlugins):
+        Call PluginInfoProvider::refresh instead.
+
+        (WebCore::Page::clearPluginData):
+        Add new setter.
+
+        * page/Page.h:
+        Declare new members.
+
+        * plugins/PluginInfoProvider.cpp:
+        (WebCore::PluginInfoProvider::refresh):
+        Put the logic to clear plug-in data and reload frames here.
+
+        * plugins/PluginInfoProvider.h:
+        Add new members.
+
 2017-01-23  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/page/Page.cpp

@@ -540 +540 @@
     Vector<Ref<Frame>> framesNeedingReload;
 
-    for (auto& page : *allPages) {
+    for (auto& page : *allPages)
         pluginInfoProviders.add(&page->pluginInfoProvider());
-        page->m_pluginData = nullptr;
-
-        if (!reload)
-            continue;
-        
-        for (Frame* frame = &page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
-            if (frame->loader().subframeLoader().containsPlugins())
-                framesNeedingReload.append(*frame);
-        }
-    }
 
     for (auto& pluginInfoProvider : pluginInfoProviders)
-        pluginInfoProvider->refreshPlugins();
-
-    for (auto& frame : framesNeedingReload)
-        frame->loader().reload();
+        pluginInfoProvider->refresh(reload);
 }
 
@@ -565 +552 @@
         m_pluginData = PluginData::create(*this);
     return *m_pluginData;
+}
+
+void Page::clearPluginData()
+{
+    m_pluginData = nullptr;
 }
 

trunk/Source/WebCore/page/Page.h

@@ -167 +167 @@
     static void refreshPlugins(bool reload);
     WEBCORE_EXPORT PluginData& pluginData();
+    void clearPluginData();
 
     WEBCORE_EXPORT void setCanStartMedia(bool);

trunk/Source/WebCore/plugins/PluginInfoProvider.cpp

@@ -27 +27 @@
 #include "PluginInfoProvider.h"
 
+#include "MainFrame.h"
+#include "Page.h"
+#include "SubframeLoader.h"
+
 namespace WebCore {
 
@@ -32 +36 @@
 {
     ASSERT(m_pages.isEmpty());
+}
+
+void PluginInfoProvider::refresh(bool reloadPages)
+{
+    Vector<Ref<Frame>> framesNeedingReload;
+
+    for (auto& page : m_pages) {
+        page->clearPluginData();
+
+        if (!reloadPages)
+            continue;
+
+        for (Frame* frame = &page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+            if (frame->loader().subframeLoader().containsPlugins())
+                framesNeedingReload.append(*frame);
+        }
+    }
+
+    for (auto& frame : framesNeedingReload)
+        frame->loader().reload();
 }
 

trunk/Source/WebCore/plugins/PluginInfoProvider.h

@@ -35 +35 @@
     virtual ~PluginInfoProvider();
 
-    void refreshPlugins(bool reloadPages);
+    void refresh(bool reloadPages);
 
     void addPage(Page&);
     void removePage(Page&);
 
-    virtual void refreshPlugins() = 0;
     virtual void getPluginInfo(Page&, Vector<PluginInfo>&) = 0;
     virtual void getWebVisiblePluginInfo(Page&, Vector<PluginInfo>&) = 0;
 
 private:
+    virtual void refreshPlugins() = 0;
+
     HashSet<Page*> m_pages;
 };

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-01-20  Anders Carlsson  <andersca@apple.com>
+
+        When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
+        https://bugs.webkit.org/show_bug.cgi?id=167268
+        rdar://problem/29857388
+
+        Reviewed by Sam Weinig.
+
+        * WebProcess/Plugins/WebPluginInfoProvider.h:
+        Make refreshPlugins() private.
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::refreshPlugins):
+        Call the newly added PluginInfoProvider::refresh().
+
 2017-01-23  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h

@@ -43 +43 @@
 #endif
 
-    void refreshPlugins() override;
-
 private:
     WebPluginInfoProvider();
@@ -50 +48 @@
     void getPluginInfo(WebCore::Page&, Vector<WebCore::PluginInfo>&) override;
     void getWebVisiblePluginInfo(WebCore::Page&, Vector<WebCore::PluginInfo>&) override;
+    void refreshPlugins() override;
 
 #if ENABLE(NETSCAPE_PLUGIN_API)

trunk/Source/WebKit2/WebProcess/WebProcess.cpp

@@ -908 +908 @@
 {
 #if ENABLE(NETSCAPE_PLUGIN_API)
-    WebPluginInfoProvider::singleton().refreshPlugins();
+    WebPluginInfoProvider::singleton().refresh(false);
 #endif
 }