⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 211092 in webkit


Ignore:
Timestamp:
Jan 24, 2017, 11:08:42 AM (10 years ago)
Author:
Joseph Pecoraro
Message:

Remove always true selectionIncludesAltImageText setting
​https://bugs.webkit.org/show_bug.cgi?id=167358

Reviewed by Alex Christensen.

Source/WebCore:

  • editing/Editor.cpp:

(WebCore::Editor::selectedTextForDataTransfer):

  • page/Settings.in:

LayoutTests:

  • editing/pasteboard/copy-image-with-alt-text-expected.txt:
  • editing/pasteboard/copy-image-with-alt-text.html:
  • platform/efl/TestExpectations:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r211090 r211092  
     12017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Remove always true selectionIncludesAltImageText setting
     4        https://bugs.webkit.org/show_bug.cgi?id=167358
     5
     6        Reviewed by Alex Christensen.
     7
     8        * editing/pasteboard/copy-image-with-alt-text-expected.txt:
     9        * editing/pasteboard/copy-image-with-alt-text.html:
     10        * platform/efl/TestExpectations:
     11
    1122017-01-24  Ryan Haddad  <ryanhaddad@apple.com>
    213

  • trunk/LayoutTests/editing/pasteboard/copy-image-with-alt-text-expected.txt

    r164526 r211092  
    22
    33Dump of markup 1:
    4 |   <shadow:root>
    5 |     <div>
    6 |       contenteditable="plaintext-only"
    7 |       "Here is an emoticon [], some more text [], an empty alt tag [], no alt tag [] and two consecutive images [].
    8 
    9 "
    10 
    11 Dump of markup 2:
    12 | <div>
    13 |   "Here is an emoticon [], some more text [], an empty alt tag [], no alt tag [] and two consecutive images []."
    14 | <div>
    15 |   <#selection-caret>
    16 |   <br>
    17 
    18 Dump of markup 3:
    194|   <shadow:root>
    205|     <div>
    … …  
    249"
    2510
    26 Dump of markup 4:
     11Dump of markup 2:
    2712| <div>
    2813|   "Here is an emoticon [:)], some more text [sample text], an empty alt tag [], no alt tag [] and two consecutive images [firstsecond]."

  • trunk/LayoutTests/editing/pasteboard/copy-image-with-alt-text.html

    r149340 r211092  
    2828window.onload = function()
    2929{
    30     if (window.internals)
    31         internals.settings.setSelectionIncludesAltImageText(false);
    32 
    3330    if (window.testRunner)
    3431        testRunner.dumpAsText();
    3532
    36     runTest();
    37     if (window.internals)
    38         internals.settings.setSelectionIncludesAltImageText(true);
    3933    runTest();
    4034

  • trunk/LayoutTests/platform/efl/TestExpectations

    r211077 r211092  
    16531653Bug(EFL) editing/pasteboard/contenteditable-pre.html [ Failure ]
    16541654Bug(EFL) editing/pasteboard/copy-backslash-with-euc.html [ Failure ]
    1655 Bug(EFL) editing/pasteboard/copy-image-with-alt-text.html [ Failure ]
    16561655Bug(EFL) editing/pasteboard/copy-in-password-field.html [ Failure ]
    16571656Bug(EFL) editing/pasteboard/copy-inside-h1-preserves-h1.html [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r211087 r211092  
     12017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Remove always true selectionIncludesAltImageText setting
     4        https://bugs.webkit.org/show_bug.cgi?id=167358
     5
     6        Reviewed by Alex Christensen.
     7
     8        * editing/Editor.cpp:
     9        (WebCore::Editor::selectedTextForDataTransfer):
     10        * page/Settings.in:
     11
    1122017-01-24  Daniel Bates  <dabates@apple.com>
    213

  • trunk/Source/WebCore/editing/Editor.cpp

    r210845 r211092  
    29442944String Editor::selectedTextForDataTransfer() const
    29452945{
    2946     if (m_frame.settings().selectionIncludesAltImageText())
    2947         return selectedText(TextIteratorEmitsImageAltText);
    2948     return selectedText();
     2946    return selectedText(TextIteratorEmitsImageAltText);
    29492947}
    29502948

  • trunk/Source/WebCore/page/Settings.in

    r211085 r211092  
    194194selectTrailingWhitespaceEnabled initial=defaultSelectTrailingWhitespaceEnabled
    195195
    196 selectionIncludesAltImageText initial=true
    197196useLegacyBackgroundSizeShorthandBehavior initial=false
    198197fixedBackgroundsPaintRelativeToDocument initial=defaultFixedBackgroundsPaintRelativeToDocument
Note: See TracChangeset for help on using the changeset viewer.