⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 211109 in webkit


Ignore:
Timestamp:
Jan 24, 2017, 1:45:13 PM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Clean up Performance IDL interfaces so they are easier to read
​https://bugs.webkit.org/show_bug.cgi?id=167378

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-24
Reviewed by Sam Weinig.

  • page/Performance.idl:
  • page/PerformanceEntry.idl:
  • page/PerformanceMark.idl:
  • page/PerformanceMeasure.idl:

Update spec links and use a typedef to match specs.

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::workerStart):

  • page/PerformanceResourceTiming.h:
  • page/PerformanceResourceTiming.idl:

Add the workerStart property which always returns 0 for non-workers.

Location:
trunk/Source/WebCore
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r211108 r211109  
     12017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Clean up Performance IDL interfaces so they are easier to read
     4        https://bugs.webkit.org/show_bug.cgi?id=167378
     5
     6        Reviewed by Sam Weinig.
     7
     8        * page/Performance.idl:
     9        * page/PerformanceEntry.idl:
     10        * page/PerformanceMark.idl:
     11        * page/PerformanceMeasure.idl:
     12        Update spec links and use a typedef to match specs.
     13
     14        * page/PerformanceResourceTiming.cpp:
     15        (WebCore::PerformanceResourceTiming::workerStart):
     16        * page/PerformanceResourceTiming.h:
     17        * page/PerformanceResourceTiming.idl:
     18        Add the workerStart property which always returns 0 for non-workers.
     19
    1202017-01-24  Zalan Bujtas  <zalan@apple.com>
    221

  • trunk/Source/WebCore/page/Performance.idl

    r207522 r211109  
    3030 */
    3131
    32 // See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationTiming/Overview.html
     32// https://w3c.github.io/hr-time/
     33
     34typedef double DOMHighResTimeStamp;
     35
    3336[
    3437    Conditional=WEB_TIMING,
    3538    GenerateIsReachable=ImplFrame,
    3639] interface Performance : EventTarget {
     40
     41    DOMHighResTimeStamp now();
     42
     43    // https://w3c.github.io/navigation-timing/
    3744    readonly attribute PerformanceNavigation navigation;
    3845    readonly attribute PerformanceTiming timing;
    3946
     47    // https://w3c.github.io/performance-timeline/
    4048    [EnabledAtRuntime=ResourceTiming] PerformanceEntryList getEntries();
    4149    [EnabledAtRuntime=ResourceTiming] PerformanceEntryList getEntriesByType(DOMString entryType);
    4250    [EnabledAtRuntime=ResourceTiming] PerformanceEntryList getEntriesByName(DOMString name, optional DOMString entryType);
    4351
     52    // https://w3c.github.io/resource-timing/
    4453    [EnabledAtRuntime=ResourceTiming] void clearResourceTimings();
    4554    [EnabledAtRuntime=ResourceTiming] void setResourceTimingBufferSize(unsigned long maxSize);
    46 
    4755    [EnabledAtRuntime=ResourceTiming] attribute EventHandler onresourcetimingbufferfull;
    4856
    49     // See http://www.w3.org/TR/2012/CR-user-timing-20120726/
    50 #if defined(ENABLE_USER_TIMING) && ENABLE_USER_TIMING
    51     [MayThrowException] void webkitMark(DOMString markName);
    52     void webkitClearMarks(optional DOMString markName);
    53 
    54     [MayThrowException] void webkitMeasure(DOMString measureName, optional DOMString startMark, optional DOMString endMark);
    55     void webkitClearMeasures(optional DOMString measureName);
    56 #endif
    57 
    58     // See http://www.w3.org/TR/hr-time/ for details.
    59     unrestricted double now();
     57    // https://w3c.github.io/user-timing/
     58    [Conditional=USER_TIMING, MayThrowException] void webkitMark(DOMString markName);
     59    [Conditional=USER_TIMING] void webkitClearMarks(optional DOMString markName);
     60    [Conditional=USER_TIMING, MayThrowException] void webkitMeasure(DOMString measureName, optional DOMString startMark, optional DOMString endMark);
     61    [Conditional=USER_TIMING] void webkitClearMeasures(optional DOMString measureName);
    6062};
    6163

  • trunk/Source/WebCore/page/PerformanceEntry.idl

    r200320 r211109  
    2929 */
    3030
    31 // See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html
     31// https://w3c.github.io/performance-timeline/
     32
     33typedef double DOMHighResTimeStamp;
     34
    3235[
    3336    Conditional=WEB_TIMING,
    … …  
    3740    readonly attribute DOMString name;
    3841    readonly attribute DOMString entryType;
    39     readonly attribute unrestricted double startTime;
    40     readonly attribute unrestricted double duration;
     42    readonly attribute DOMHighResTimeStamp startTime;
     43    readonly attribute DOMHighResTimeStamp duration;
    4144};

  • trunk/Source/WebCore/page/PerformanceMark.idl

    r149845 r211109  
    2424 */
    2525
     26// https://w3c.github.io/user-timing/
     27
    2628[
    2729    Conditional=USER_TIMING,

  • trunk/Source/WebCore/page/PerformanceMeasure.idl

    r149845 r211109  
    2424 */
    2525
     26// https://w3c.github.io/user-timing/
     27
    2628[
    2729    Conditional=USER_TIMING,

  • trunk/Source/WebCore/page/PerformanceResourceTiming.cpp

    r211074 r211109  
    9595}
    9696
     97double PerformanceResourceTiming::workerStart() const
     98{
     99    return 0.0;
     100}
     101
    97102double PerformanceResourceTiming::redirectStart() const
    98103{

  • trunk/Source/WebCore/page/PerformanceResourceTiming.h

    r211074 r211109  
    5656    AtomicString initiatorType() const;
    5757
     58    double workerStart() const;
    5859    double redirectStart() const;
    5960    double redirectEnd() const;

  • trunk/Source/WebCore/page/PerformanceResourceTiming.idl

    r204976 r211109  
    2929 */
    3030
    31 // See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/ResourceTiming/Overview.html
     31// https://w3c.github.io/resource-timing/
     32
     33typedef double DOMHighResTimeStamp;
     34
    3235[
    3336    Conditional=WEB_TIMING,
    … …  
    3639    readonly attribute DOMString initiatorType;
    3740
    38     readonly attribute unrestricted double redirectStart;
    39     readonly attribute unrestricted double redirectEnd;
    40     readonly attribute unrestricted double fetchStart;
    41     readonly attribute unrestricted double domainLookupStart;
    42     readonly attribute unrestricted double domainLookupEnd;
    43     readonly attribute unrestricted double connectStart;
    44     readonly attribute unrestricted double connectEnd;
    45     readonly attribute unrestricted double secureConnectionStart;
    46     readonly attribute unrestricted double requestStart;
    47     readonly attribute unrestricted double responseStart;
    48     readonly attribute unrestricted double responseEnd;
     41    readonly attribute DOMHighResTimeStamp workerStart;
     42    readonly attribute DOMHighResTimeStamp redirectStart;
     43    readonly attribute DOMHighResTimeStamp redirectEnd;
     44    readonly attribute DOMHighResTimeStamp fetchStart;
     45    readonly attribute DOMHighResTimeStamp domainLookupStart;
     46    readonly attribute DOMHighResTimeStamp domainLookupEnd;
     47    readonly attribute DOMHighResTimeStamp connectStart;
     48    readonly attribute DOMHighResTimeStamp connectEnd;
     49    readonly attribute DOMHighResTimeStamp secureConnectionStart;
     50    readonly attribute DOMHighResTimeStamp requestStart;
     51    readonly attribute DOMHighResTimeStamp responseStart;
     52    readonly attribute DOMHighResTimeStamp responseEnd;
    4953};
Note: See TracChangeset for help on using the changeset viewer.