Changeset 211131 in webkit

Timestamp:

Jan 24, 2017, 6:59:11 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167311

Patch by Antoine Quint <Antoine Quint> on 2017-01-24
Reviewed by Dean Jackson.

Source/WebCore:

Ensure we have a chance to start the transition (on the next frame) before registering for an event
tracking its completion.

• Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype.hide):

LayoutTests:

This test should no longer be flaky, so let's no mark it as such anymore.

• platform/mac/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-01-24  Antoine Quint  <graouts@apple.com>
+
+        LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=167311
+
+        Reviewed by Dean Jackson.
+
+        This test should no longer be flaky, so let's no mark it as such anymore.
+
+        * platform/mac/TestExpectations:
+
 2017-01-24  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1494 +1494 @@
 webkit.org/b/167275 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
 
-webkit.org/b/167311 [ Debug ] media/modern-media-controls/tracks-panel/tracks-panel-hide.html [ Pass Timeout ]
-
 webkit.org/b/167347 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-24  Antoine Quint  <graouts@apple.com>
+
+        LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=167311
+
+        Reviewed by Dean Jackson.
+
+        Ensure we have a chance to start the transition (on the next frame) before registering for an event
+        tracking its completion.
+
+        * Modules/modern-media-controls/controls/tracks-panel.js:
+        (TracksPanel.prototype.hide):
+
 2017-01-24  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js

@@ -44 +44 @@
 
         this.element.addEventListener("transitionend", this);
-        this.element.classList.add("fade-out");
+
+        // Ensure a transition will indeed happen by starting it only on the next frame.
+        window.requestAnimationFrame(() => { this.element.classList.add("fade-out") });
     }