⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 211149 in webkit


Ignore:
Timestamp:
Jan 25, 2017, 9:42:44 AM (10 years ago)
Author:
Simon Fraser
Message:

Revert r210882, removing support for background-repeat-x/y
​https://bugs.webkit.org/show_bug.cgi?id=167223

Reviewed by Myles Maxfield.
Source/WebCore:

CSSPropertyBackgroundRepeatX and CSSPropertyBackgroundRepeatY only exist to make it easier
to parse CSSPropertyBackgroundRepeat as if it were a shorthand; they were never intended to
be web-exposed. r210882 mistakenly expose them to the web, so undo that patch, and annotate
the properties in CSSProperties.json with a flag which indicates their special status.

In addition, remove background-repeat-x/y from the list of properties allowed in video cues,
since these are not valid properties.

  • css/CSSProperties.json:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::isValidCueStyleProperty):

  • css/makeprop.pl:

(addProperty):

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isKeywordPropertyID):

LayoutTests:

Modify the test to check that background-repeat-x and background-repeat-y are not parsed.

  • fast/backgrounds/background-repeat-x-y-parse-expected.txt:
  • fast/backgrounds/background-repeat-x-y-parse.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r211148 r211149  
     12017-01-25  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Revert r210882, removing support for background-repeat-x/y
     4        https://bugs.webkit.org/show_bug.cgi?id=167223
     5
     6        Reviewed by Myles Maxfield.
     7       
     8        Modify the test to check that background-repeat-x and background-repeat-y are not parsed.
     9
     10        * fast/backgrounds/background-repeat-x-y-parse-expected.txt:
     11        * fast/backgrounds/background-repeat-x-y-parse.html:
     12
    1132017-01-25  Youenn Fablet  <youenn@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r211145 r211149  
     12017-01-25  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Revert r210882, removing support for background-repeat-x/y
     4        https://bugs.webkit.org/show_bug.cgi?id=167223
     5
     6        Reviewed by Myles Maxfield.
     7
     8        CSSPropertyBackgroundRepeatX and CSSPropertyBackgroundRepeatY only exist to make it easier
     9        to parse CSSPropertyBackgroundRepeat as if it were a shorthand; they were never intended to
     10        be web-exposed. r210882 mistakenly expose them to the web, so undo that patch, and annotate
     11        the properties in CSSProperties.json with a flag which indicates their special status.
     12
     13        In addition, remove background-repeat-x/y from the list of properties allowed in video cues,
     14        since these are not valid properties.
     15
     16        * css/CSSProperties.json:
     17        * css/StyleResolver.cpp:
     18        (WebCore::StyleResolver::isValidCueStyleProperty):
     19        * css/makeprop.pl:
     20        (addProperty):
     21        * css/parser/CSSParserFastPaths.cpp:
     22        (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     23
    1242017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
    225

  • trunk/Source/WebCore/css/CSSProperties.json

    r210024 r211149  
    683683            "codegen-properties": {
    684684                "name-for-methods": "RepeatX",
    685                 "fill-layer-property": true
     685                "fill-layer-property": true,
     686                "internal-only": true
    686687            }
    687688        },
    … …  
    689690            "codegen-properties": {
    690691                "name-for-methods": "RepeatY",
    691                 "fill-layer-property": true
     692                "fill-layer-property": true,
     693                "internal-only": true
    692694            }
    693695        },
    … …  
    35433545            "codegen-properties": {
    35443546                "name-for-methods": "RepeatX",
    3545                 "fill-layer-property": true
     3547                "fill-layer-property": true,
     3548                "internal-only": true
    35463549            }
    35473550        },
    … …  
    35493552            "codegen-properties": {
    35503553                "name-for-methods": "RepeatY",
    3551                 "fill-layer-property": true
     3554                "fill-layer-property": true,
     3555                "internal-only": true
    35523556            }
    35533557        },

  • trunk/Source/WebCore/css/StyleResolver.cpp

    r210828 r211149  
    14841484    case CSSPropertyBackgroundPositionY:
    14851485    case CSSPropertyBackgroundRepeat:
    1486     case CSSPropertyBackgroundRepeatX:
    1487     case CSSPropertyBackgroundRepeatY:
    14881486    case CSSPropertyBackgroundSize:
    14891487    case CSSPropertyColor:

  • trunk/Source/WebCore/css/makeprop.pl

    r210758 r211149  
    140140                } elsif ($styleBuilderOptions{$codegenOptionName}) {
    141141                    $propertiesWithStyleBuilderOptions{$name}{$codegenOptionName} = $codegenProperties->{$codegenOptionName};
     142                } elsif ($codegenOptionName eq "internal-only") {
     143                    # internal-only properties exist to make it easier to parse compound properties (e.g. background-repeat) as if they were shorthands. This doesn't currently affect codegen.
    142144                } else {
    143145                    die "Unrecognized codegen property \"$optionName\" for $name property.";
Note: See TracChangeset for help on using the changeset viewer.