⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 211152 in webkit


Ignore:
Timestamp:
Jan 25, 2017, 10:00:49 AM (10 years ago)
Author:
Simon Fraser
Message:

Revert r210882, removing support for background-repeat-x/y
​https://bugs.webkit.org/show_bug.cgi?id=167223

Reviewed by Myles Maxfield.

Fix the layout tests.

fast/backgrounds/background-repeat-x-y.html was mistakenly removed in r211060 so
remove its expected. Fix the parsing test.

  • fast/backgrounds/background-repeat-x-y-expected.html: Removed.
  • fast/backgrounds/background-repeat-x-y-parse-expected.txt:
  • fast/backgrounds/background-repeat-x-y-parse.html:
Location:
trunk/LayoutTests
Files:
1 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r211149 r211152  
     12017-01-25  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Revert r210882, removing support for background-repeat-x/y
     4        https://bugs.webkit.org/show_bug.cgi?id=167223
     5
     6        Reviewed by Myles Maxfield.
     7       
     8        Fix the layout tests.
     9       
     10        fast/backgrounds/background-repeat-x-y.html was mistakenly removed in r211060 so
     11        remove its expected. Fix the parsing test.
     12
     13        * fast/backgrounds/background-repeat-x-y-expected.html: Removed.
     14        * fast/backgrounds/background-repeat-x-y-parse-expected.txt:
     15        * fast/backgrounds/background-repeat-x-y-parse.html:
     16
    1172017-01-25  Simon Fraser  <simon.fraser@apple.com>
    218

  • trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse-expected.txt

    r210882 r211152  
     1This test checks that background-repeat-x/y are not parsed
     2
     3On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
     4
     5
    16PASS window.getComputedStyle(document.getElementById('test1')).getPropertyValue('background-repeat') is "repeat"
    2 PASS window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat') is "repeat-y"
    3 PASS window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat') is "repeat"
     7PASS window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat') is "repeat"
     8PASS window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat') is "repeat-y"
    49PASS window.getComputedStyle(document.getElementById('test4')).getPropertyValue('background-repeat') is "repeat-x"
    5 PASS window.getComputedStyle(document.getElementById('test5')).getPropertyValue('background-repeat') is "no-repeat"
    6 PASS window.getComputedStyle(document.getElementById('test6')).getPropertyValue('background-repeat') is "no-repeat"
    7 PASS window.getComputedStyle(document.getElementById('test7')).getPropertyValue('background-repeat') is "no-repeat"
    8 PASS window.getComputedStyle(document.getElementById('test8')).getPropertyValue('background-repeat') is "repeat-x"
    9 PASS window.getComputedStyle(document.getElementById('test9')).getPropertyValue('background-repeat') is "repeat-y"
    10 PASS window.getComputedStyle(document.getElementById('test10')).getPropertyValue('background-repeat') is "repeat"
    1110PASS successfullyParsed is true
    1211
    1312TEST COMPLETE
    14         
     13   

  • trunk/LayoutTests/fast/backgrounds/background-repeat-x-y-parse.html

    r210882 r211152  
    44<style>
    55.test {
    6         display: inline-block;
    7         width: 150px;
    8         height: 150px;
    9         background-image: url('resources/map.jpg');
    10         background-position: top left;
     6    display: inline-block;
     7    width: 150px;
     8    height: 150px;
     9    background-image: url('resources/map.jpg');
     10    background-position: top left;
     11    border: 1px solid black;
    1112}
    1213</style>
    … …  
    1415</head>
    1516<body>
    16 <div id="test1" class="test" style="background-repeat-x: repeat; border: 1px solid black;"></div>
    17 <div id="test2" class="test" style="background-repeat-x: no-repeat; border: 1px solid black;"></div>
    18 <div id="test3" class="test" style="background-repeat-y: repeat; border: 1px solid black;"></div>
    19 <div id="test4" class="test" style="background-repeat-y: no-repeat; border: 1px solid black;"></div>
    20 <div id="test5" class="test" style="background-repeat-x: no-repeat; background-repeat-y: no-repeat; border: 1px solid black;"></div>
    21 <div id="test6" class="test" style="background-repeat: repeat-y; background-repeat-y: no-repeat; border: 1px solid black;"></div>
    22 <div id="test7" class="test" style="background-repeat: repeat-x; background-repeat-x: no-repeat; border: 1px solid black;"></div>
    23 <div id="test8" class="test" style="background-repeat-x: no-repeat; background-repeat: repeat-x; border: 1px solid black;"></div>
    24 <div id="test9" class="test" style="background-repeat-y: no-repeat; background-repeat: repeat-y; border: 1px solid black;"></div>
    25 <div id="test10" class="test" style="background-repeat-x: garbage; border: 1px solid black;"></div>
     17<div id="test1" class="test" style="background-repeat-y: no-repeat;"></div>
     18<div id="test2" class="test" style="background-repeat-x: no-repeat; background-repeat-y: no-repeat;"></div>
     19<div id="test3" class="test" style="background-repeat: repeat-y; background-repeat-y: no-repeat;"></div>
     20<div id="test4" class="test" style="background-repeat: repeat-x; background-repeat-x: no-repeat;"></div>
    2621<script>
     22description("This test checks that background-repeat-x/y are not parsed");
     23
    2724shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).getPropertyValue('background-repeat')", "repeat");
    28 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat')", "repeat-y");
    29 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat')", "repeat");
     25shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).getPropertyValue('background-repeat')", "repeat");
     26shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).getPropertyValue('background-repeat')", "repeat-y");
    3027shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).getPropertyValue('background-repeat')", "repeat-x");
    31 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).getPropertyValue('background-repeat')", "no-repeat");
    32 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).getPropertyValue('background-repeat')", "no-repeat");
    33 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test7')).getPropertyValue('background-repeat')", "no-repeat");
    34 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test8')).getPropertyValue('background-repeat')", "repeat-x");
    35 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test9')).getPropertyValue('background-repeat')", "repeat-y");
    36 shouldBeEqualToString("window.getComputedStyle(document.getElementById('test10')).getPropertyValue('background-repeat')", "repeat");
    3728</script>
    3829<script src="../../resources/js-test-post.js"></script>
Note: See TracChangeset for help on using the changeset viewer.