Changeset 211242 in webkit

Timestamp:

Jan 26, 2017 4:57:36 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r210328.
​https://bugs.webkit.org/show_bug.cgi?id=167476

Blocking bug is fixed <rdar://problem/29957753> (Requested by
keith_miller on #webkit).

Reverted changeset:

"Disable smooth playhead animation for main content media in
the Touch Bar"
​https://bugs.webkit.org/show_bug.cgi?id=166715
​http://trac.webkit.org/changeset/210328

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/WebPlaybackSessionInterfaceMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-26  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r210328.
+        https://bugs.webkit.org/show_bug.cgi?id=167476
+
+        Blocking bug is fixed <rdar://problem/29957753> (Requested by
+        keith_miller on #webkit).
+
+        Reverted changeset:
+
+        "Disable smooth playhead animation for main content media in
+        the Touch Bar"
+        https://bugs.webkit.org/show_bug.cgi?id=166715
+        http://trac.webkit.org/changeset/210328
+
 2017-01-26  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm

@@ -221 +221 @@
         effectivePlaybackRate = 0;
 
-    // FIXME: The timing value should ideally use the effective playback rate, but this causes AVKit to indefinitely fire a repeating timer.
-    // More investigation will be required before we re-enable smooth playhead animation -- for now, we should just pretend that the playback
-    // rate is always 0.
-    manager.timing = [getAVValueTimingClass() valueTimingWithAnchorValue:currentTime anchorTimeStamp:effectiveAnchorTime rate:0];
+    manager.timing = [getAVValueTimingClass() valueTimingWithAnchorValue:currentTime anchorTimeStamp:effectiveAnchorTime rate:effectivePlaybackRate];
 }