Changeset 211300 in webkit

Timestamp:

Jan 27, 2017, 1:01:50 PM (10 years ago)

Author:

fpizlo@apple.com

Message:

scanExternalRememberedSet needs to mergeIfNecessary
​https://bugs.webkit.org/show_bug.cgi?id=167523

Reviewed by Keith Miller.

The protocol for opaque roots is that if you add to them outside of draining, then you need to call
mergeIfNecessary.

This means that every MarkingConstraint that adds opaque roots needs to mergeIfNecessary after.

scanExternalRememberedSet transitively calls addOpaqueRoot, is called from a MarkingConstraint, and
was missing a call to mergeIfNecessary. This fixes it.

• API/JSVirtualMachine.mm:

(scanExternalRememberedSet):

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSVirtualMachine.mm (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSVirtualMachine.mm

@@ -327 +327 @@
         [externalRememberedSet removeAllObjects];
     }
+
+    visitor.mergeIfNecessary();
 }
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-01-27  Filip Pizlo  <fpizlo@apple.com>
+
+        scanExternalRememberedSet needs to mergeIfNecessary
+        https://bugs.webkit.org/show_bug.cgi?id=167523
+
+        Reviewed by Keith Miller.
+        
+        The protocol for opaque roots is that if you add to them outside of draining, then you need to call
+        mergeIfNecessary.
+        
+        This means that every MarkingConstraint that adds opaque roots needs to mergeIfNecessary after.
+        
+        scanExternalRememberedSet transitively calls addOpaqueRoot, is called from a MarkingConstraint, and
+        was missing a call to mergeIfNecessary. This fixes it.
+
+        * API/JSVirtualMachine.mm:
+        (scanExternalRememberedSet):
+
 2017-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>