Changeset 211306 in webkit

Timestamp:

Jan 27, 2017, 3:29:26 PM (10 years ago)

Author:

Yusuke Suzuki

Message:

Extend create_hash_table to specify Intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=167505

Reviewed by Sam Weinig.

This patch extends create_hash_table to specify Intrinsic.
We can set Intrinsic in the static property table definition
in runtime/XXX.h.

And drop the adhoc code for String.fromCharCode in create_hash_table.

• create_hash_table:
• runtime/StringConstructor.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• create_hash_table (modified) (5 diffs)
• runtime/StringConstructor.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-01-27  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        Extend create_hash_table to specify Intrinsic
+        https://bugs.webkit.org/show_bug.cgi?id=167505
+
+        Reviewed by Sam Weinig.
+
+        This patch extends create_hash_table to specify Intrinsic.
+        We can set Intrinsic in the static property table definition
+        in runtime/XXX.h.
+
+        And drop the adhoc code for String.fromCharCode in create_hash_table.
+
+        * create_hash_table:
+        * runtime/StringConstructor.cpp:
+
 2017-01-27  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/create_hash_table

@@ -77 +77 @@
 
         $inside = 0;
-    } elsif (/^(\S+)\s*(\S+)\s*([\w\|]*)\s*(\w*)\s*$/ && $inside) {
+    } elsif (/^(\S+)\s*(\S+)\s*([\w\|]*)\s*(\w*)\s*(\w*)\s*$/ && $inside) {
         my $key = $1;
         my $val = $2;
         my $att = $3;
         my $param = $4;
+        my $intrinsic = $5;
 
         push(@keys, $key);
@@ -91 +92 @@
 
         if ($att =~ m/Function/) {
-            push(@values, { "type" => "Function", "function" => $val, "params" => (length($param) ? $param : "") });
+            push(@values, { "type" => "Function", "function" => $val, "params" => (length($param) ? $param : ""), "intrinsic" => (length($intrinsic) ? $intrinsic : "NoIntrinsic") });
             #printf STDERR "WARNING: Number of arguments missing for $key/$val\n" if (length($param) == 0);
         } elsif ($att =~ m/Accessor/) {
@@ -302 +303 @@
         my $firstCastStr = "";
         my $secondCastStr = "";
+        my $intrinsic = "NoIntrinsic";
 
         if ($values[$i]{"type"} eq "Function") {
@@ -307 +309 @@
             $firstValue = $values[$i]{"function"};
             $secondValue = $values[$i]{"params"};
+            $intrinsic = $values[$i]{"intrinsic"};
         } elsif ($values[$i]{"type"} eq "Accessor") {
             $firstCastStr = "static_cast<NativeFunction>";
@@ -330 +333 @@
         }
 
-        my $intrinsic = "NoIntrinsic";
-        $intrinsic = "FromCharCodeIntrinsic" if ($key eq "fromCharCode");
-        if ($name eq "arrayPrototypeTable") {
-            $intrinsic = "ArrayPushIntrinsic" if ($key eq "push");
-            $intrinsic = "ArrayPopIntrinsic" if ($key eq "pop");
-        }
-
         if ($values[$i]{"type"} eq "Function" && $firstValue eq "JSBuiltin")  {
             my $tableHead = $name;

trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp

@@ -45 +45 @@
 /* Source for StringConstructor.lut.h
 @begin stringConstructorTable
-  fromCharCode          stringFromCharCode         DontEnum|Function 1
+  fromCharCode          stringFromCharCode         DontEnum|Function 1 FromCharCodeIntrinsic
   fromCodePoint         stringFromCodePoint        DontEnum|Function 1
   raw                   JSBuiltin                  DontEnum|Function 1