Changeset 211492 in webkit


Ignore:
Timestamp:
Feb 1, 2017 10:15:13 AM (7 years ago)
Author:
Wenson Hsieh
Message:

[WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
https://bugs.webkit.org/show_bug.cgi?id=167695
<rdar://problem/30305390>

Reviewed by Sam Weinig.

Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
is destroyed.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Location:
trunk/Source/WebKit/mac
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/mac/ChangeLog

    r211468 r211492  
     12017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
     4        https://bugs.webkit.org/show_bug.cgi?id=167695
     5        <rdar://problem/30305390>
     6
     7        Reviewed by Sam Weinig.
     8
     9        Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
     10        exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
     11        is destroyed.
     12
     13        * WebView/WebView.mm:
     14        (-[WebView _commonInitializationWithFrameName:groupName:]):
     15
    1162017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
    217
  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r211355 r211492  
    13551355    // FIXME: We should enable this on iOS as well.
    13561356    pageConfiguration.validationMessageClient = std::make_unique<WebValidationMessageClient>(self);
    1357 #if ENABLE(DRAG_SUPPORT)
    1358     pageConfiguration.dragClient = new WebDragClient(self);
    1359 #endif
    13601357    pageConfiguration.inspectorClient = new WebInspectorClient(self);
    13611358#else
    13621359    pageConfiguration.chromeClient = new WebChromeClientIOS(self);
    13631360    pageConfiguration.inspectorClient = new WebInspectorClient(self);
     1361#endif
     1362
     1363#if ENABLE(DRAG_SUPPORT)
     1364    pageConfiguration.dragClient = new WebDragClient(self);
    13641365#endif
    13651366
Note: See TracChangeset for help on using the changeset viewer.