Changeset 211579 in webkit

Timestamp:

Feb 2, 2017 11:33:09 AM (7 years ago)

Author:

Brent Fulgham

Message:

Correct memory leak in MediaConstraints
​https://bugs.webkit.org/show_bug.cgi?id=167744
<rdar://problem/30331444>

Reviewed by Anders Carlsson.

ConstraintHolder returns a reference to an object created by operator new. When the
returned value is assigned or stored in Vector or other containers we leak memory.
Instead, this value should just be returned as a regular object so that the return
value optimization can make sure memory is properly (and efficiently) used.

• platform/mediastream/MediaConstraints.h:

(WebCore::FlattenedConstraint::ConstraintHolder::create): Return by value.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/MediaConstraints.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-02-02  Brent Fulgham  <bfulgham@apple.com>
+
+        Correct memory leak in MediaConstraints
+        https://bugs.webkit.org/show_bug.cgi?id=167744
+        <rdar://problem/30331444>
+
+        Reviewed by Anders Carlsson.
+
+        ConstraintHolder returns a reference to an object created by operator new. When the
+        returned value is assigned or stored in Vector or other containers we leak memory.
+        Instead, this value should just be returned as a regular object so that the return
+        value optimization can make sure memory is properly (and efficiently) used.
+
+        * platform/mediastream/MediaConstraints.h:
+        (WebCore::FlattenedConstraint::ConstraintHolder::create): Return by value.
+
 2017-02-02  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/platform/mediastream/MediaConstraints.h

@@ -714 +714 @@
     class ConstraintHolder {
     public:
-        static ConstraintHolder& create(const MediaConstraint& value) { return *new ConstraintHolder(value); }
+        static ConstraintHolder create(const MediaConstraint& value) { return ConstraintHolder(value); }
 
         ~ConstraintHolder()