Changeset 211601 in webkit
- Timestamp:
- Feb 2, 2017 3:21:34 PM (7 years ago)
- Location:
- trunk/Source/WebKit2
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r211598 r211601 1 2017-02-02 Megan Gardner <megan_gardner@apple.com> 2 3 Don't attempt wide gammut on older OSes 4 https://bugs.webkit.org/show_bug.cgi?id=167754 5 <rdar://problem/29931587> 6 7 Reviewed by Tim Horton. 8 9 We need to guard our extended color checks the same way throughout the code, or we will attempt to set up 10 support for wide gamut partially, which causes crashes when using sharable bitmap. 11 12 * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: 13 (WebKit::convertImageToBitmap): 14 * WebProcess/WebPage/ios/WebPageIOS.mm: 15 (WebKit::WebPage::getPositionInformation): 16 1 17 2017-02-02 Enrica Casucci <enrica@apple.com> 2 18 -
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
r211597 r211601 63 63 { 64 64 ShareableBitmap::Flags flags = ShareableBitmap::SupportsAlpha; 65 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 65 66 if (screenSupportsExtendedColor(frame.mainFrame().view())) 66 67 flags |= ShareableBitmap::SupportsExtendedColor; 68 #endif 67 69 auto bitmap = ShareableBitmap::createShareable(size, flags); 68 70 if (!bitmap) -
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
r211538 r211601 2489 2489 // FIXME: Only select ExtendedColor on images known to need wide gamut 2490 2490 ShareableBitmap::Flags flags = ShareableBitmap::SupportsAlpha; 2491 #if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000 2491 2492 flags |= screenSupportsExtendedColor() ? ShareableBitmap::SupportsExtendedColor : 0; 2493 #endif 2492 2494 if (RefPtr<ShareableBitmap> sharedBitmap = ShareableBitmap::createShareable(IntSize(bitmapSize), flags)) { 2493 2495 auto graphicsContext = sharedBitmap->createGraphicsContext();
Note: See TracChangeset
for help on using the changeset viewer.