Changeset 211798 in webkit

Timestamp:

Feb 7, 2017 1:34:18 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r211277 - [GTK] Stop forcing accelerated compositing by default
​https://bugs.webkit.org/show_bug.cgi?id=167492

Reviewed by Žan Doberšek.

We are now ready to bring back the on demand accelerated compositing mode with the threaded
compositor. Unfortunately, having AC always enabled brought a lot of issues for many people. Not only it
requires a lot more memory but also caused rendering issues (or even nothing rendered at all) with some graphics
drivers. People started to use WEBKIT_DISABLE_COMPOSITING_MODE as a workaround, but that was not expected to be
used by users. So, entering/leaving AC when required by web contents is not actually the solution but a huge
improvement for many people. If we are eventually ready to force AC mode again, we'll change this again. Note
that we still have WEBKIT_DISABLE_COMPOSITING_MODE, but now also WEBKIT_FORCE_COMPOSITING_MODE for testing and debugging.

• UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):

Location:

releases/WebKitGTK/webkit-2.14/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/WebPreferencesGtk.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Stop forcing accelerated compositing by default
+        https://bugs.webkit.org/show_bug.cgi?id=167492
+
+        Reviewed by Žan Doberšek.
+
+        We are now ready to bring back the on demand accelerated compositing mode with the threaded
+        compositor. Unfortunately, having AC always enabled brought a lot of issues for many people. Not only it
+        requires a lot more memory but also caused rendering issues (or even nothing rendered at all) with some graphics
+        drivers. People started to use WEBKIT_DISABLE_COMPOSITING_MODE as a workaround, but that was not expected to be
+        used by users. So, entering/leaving AC when required by web contents is not actually the solution but a huge
+        improvement for many people. If we are eventually ready to force AC mode again, we'll change this again. Note
+        that we still have WEBKIT_DISABLE_COMPOSITING_MODE, but now also WEBKIT_FORCE_COMPOSITING_MODE for testing and debugging.
+
+        * UIProcess/gtk/WebPreferencesGtk.cpp:
+        (WebKit::WebPreferences::platformInitializeStore):
+
 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
 

releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp

@@ -45 +45 @@
     setAcceleratedCompositingEnabled(false);
 #else
-#if USE(COORDINATED_GRAPHICS_THREADED)
-    setForceCompositingMode(true);
-#else
-    const char* force_compositing = getenv("WEBKIT_FORCE_COMPOSITING_MODE");
-    if (force_compositing && strcmp(force_compositing, "0"))
+    const char* forceCompositing = getenv("WEBKIT_FORCE_COMPOSITING_MODE");
+    if (forceCompositing && strcmp(forceCompositing, "0"))
         setForceCompositingMode(true);
-#endif
 
-    const char* disable_compositing = getenv("WEBKIT_DISABLE_COMPOSITING_MODE");
-    if (disable_compositing && strcmp(disable_compositing, "0")) {
+    const char* disableCompositing = getenv("WEBKIT_DISABLE_COMPOSITING_MODE");
+    if (disableCompositing && strcmp(disableCompositing, "0")) {
         setAcceleratedCompositingEnabled(false);
         return;