Changeset 212372 in webkit

Timestamp:

Feb 15, 2017, 9:58:05 AM (10 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
​https://bugs.webkit.org/show_bug.cgi?id=168329
<rdar://problem/30518832>

Reviewed by Daniel Bates.

When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
never change given the same input arguments. Memoize function for efficiency.

• Scripts/webkitpy/port/darwin.py: Add memoized import.

(DarwinPort):
(DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-02-15  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
+        https://bugs.webkit.org/show_bug.cgi?id=168329
+        <rdar://problem/30518832>
+
+        Reviewed by Daniel Bates.
+
+        When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
+        never change given the same input arguments.  Memoize function for efficiency.
+
+        * Scripts/webkitpy/port/darwin.py: Add memoized import.
+        (DarwinPort):
+        (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
+        
+
 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -24 +24 @@
 import os
 
+from webkitpy.common.memoized import memoized
 from webkitpy.common.system.crashlogs import CrashLogs
 from webkitpy.common.system.executive import ScriptError
@@ -175 +176 @@
             return fallback
 
+    @memoized
     def app_identifier_from_bundle(self, app_bundle):
         plist_path = self._filesystem.join(app_bundle, 'Info.plist')