Changeset 212730 in webkit

Timestamp:

Feb 21, 2017, 11:21:31 AM (10 years ago)

Author:

pvollan@apple.com

Message:

[Win] WebView is not painting in accelerated compositing mode.
​https://bugs.webkit.org/show_bug.cgi?id=168654

Reviewed by Brent Fulgham.

Initializing the uncommitted layer change flags to CoverageRectChanged in GraphicsLayerCA,
stops WebView painting in accelerated mode.

Covered by existing tests.

• platform/graphics/ca/GraphicsLayerCA.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/GraphicsLayerCA.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-02-21  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] WebView is not painting in accelerated compositing mode.
+        https://bugs.webkit.org/show_bug.cgi?id=168654
+
+        Reviewed by Brent Fulgham.
+
+        Initializing the uncommitted layer change flags to CoverageRectChanged in GraphicsLayerCA,
+        stops WebView painting in accelerated mode.
+
+        Covered by existing tests.
+
+        * platform/graphics/ca/GraphicsLayerCA.h:
+
 2017-02-21  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h

@@ -587 +587 @@
     FloatSize m_pixelAlignmentOffset;
 
+#if PLATFORM(WIN)
+    // FIXME: when initializing m_uncommittedChanges to a non-zero value, nothing is painted on Windows, see https://bugs.webkit.org/show_bug.cgi?id=168666.
+    LayerChangeFlags m_uncommittedChanges { 0 };
+#else
     LayerChangeFlags m_uncommittedChanges { CoverageRectChanged };
+#endif
+
     bool m_isCommittingChanges { false };
 };