Changeset 212839 in webkit

Timestamp:

Feb 22, 2017, 10:03:13 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
​https://bugs.webkit.org/show_bug.cgi?id=168721

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-02-22
Reviewed by Michael Catanzaro.

Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
criticals.

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::continuousMouseScrollBy):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
+        https://bugs.webkit.org/show_bug.cgi?id=168721
+
+        Reviewed by Michael Catanzaro.
+
+        Use WTFLogAlways instead. It's still shown in stderr, but it won't crash if we ever run tests with fatal
+        criticals.
+
+        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+        (WTR::EventSenderProxy::continuousMouseScrollBy):
+
 2017-02-21  Youenn Fablet  <youenn@apple.com>
 

trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp

@@ -442 +442 @@
 {
     // Gtk+ does not support paged scroll events.
-    g_return_if_fail(!paged);
+    if (paged) {
+        WTFLogAlways("EventSenderProxy::continuousMouseScrollBy not implemented for paged scroll events");
+        return;
+    }
 
     GdkEvent* event = gdk_event_new(GDK_SCROLL);