Changeset 212846 in webkit

Timestamp:

Feb 22, 2017, 12:46:32 PM (10 years ago)

Author:

jer.noble@apple.com

Message:

Source/WebCore:
MediaStreamSourceNode never receives audio from MockRealtimeAudioSourceMac.
​https://bugs.webkit.org/show_bug.cgi?id=168731

Reviewed by Eric Carlson.

Test: fast/mediastream/mock-media-source-webaudio.html

Because the audioSourceProvider can be created before the mock source is configured, explicitly configure the
source if necessary after creating the audioSourceProvider.

• platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::audioSourceProvider):

LayoutTests:
MediaStreamSourceNode never receives audio from a getUserMedia() created stream
​https://bugs.webkit.org/show_bug.cgi?id=168731

Reviewed by Eric Carlson.

• fast/mediastream/mock-media-source-webaudio-expected.txt: Added.
• fast/mediastream/mock-media-source-webaudio.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/mediastream/mock-media-source-webaudio-expected.txt (added)
• LayoutTests/fast/mediastream/mock-media-source-webaudio.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/mediastream/mac/MockRealtimeAudioSourceMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-02-22  Jer Noble  <jer.noble@apple.com>
+
+        MediaStreamSourceNode never receives audio from a getUserMedia() created stream
+        https://bugs.webkit.org/show_bug.cgi?id=168731
+
+        Reviewed by Eric Carlson.
+
+        * fast/mediastream/mock-media-source-webaudio-expected.txt: Added.
+        * fast/mediastream/mock-media-source-webaudio.html: Added.
+
 2017-02-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-02-22  Jer Noble  <jer.noble@apple.com>
+
+        MediaStreamSourceNode never receives audio from MockRealtimeAudioSourceMac.
+        https://bugs.webkit.org/show_bug.cgi?id=168731
+
+        Reviewed by Eric Carlson.
+
+        Test: fast/mediastream/mock-media-source-webaudio.html
+
+        Because the audioSourceProvider can be created before the mock source is configured, explicitly configure the
+        source if necessary after creating the audioSourceProvider.
+
+        * platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:
+        (WebCore::MockRealtimeAudioSourceMac::audioSourceProvider):
+
 2017-02-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/MockRealtimeAudioSourceMac.mm

@@ -204 +204 @@
 {
     if (!m_audioSourceProvider) {
+        if (!m_audioBufferList)
+            reconfigure();
+
         m_audioSourceProvider = WebAudioSourceProviderAVFObjC::create(*this);
         m_audioSourceProvider->prepare(&m_streamFormat);