Changeset 212927 in webkit


Ignore:
Timestamp:
Feb 23, 2017 2:52:55 PM (7 years ago)
Author:
achristensen@apple.com
Message:

Re-soft-link CoreVideo after r212906
​https://bugs.webkit.org/show_bug.cgi?id=168803

Reviewed by Jer Noble.

CoreVideo should be soft linked to reduce startup time.
Linking against the framework just for a few symbols used in one file was the wrong solution.

  • Configurations/WebCore.xcconfig:
  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r212920 r212927  
     12017-02-23  Alex Christensen  <achristensen@webkit.org>
     2
     3        Re-soft-link CoreVideo after r212906
     4        https://bugs.webkit.org/show_bug.cgi?id=168803
     5
     6        Reviewed by Jer Noble.
     7
     8        CoreVideo should be soft linked to reduce startup time.
     9        Linking against the framework just for a few symbols used in one file was the wrong solution.
     10
     11        * Configurations/WebCore.xcconfig:
     12        * platform/cocoa/CoreVideoSoftLink.cpp:
     13        * platform/cocoa/CoreVideoSoftLink.h:
     14        * platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
     15
    1162017-02-23  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/Configurations/WebCore.xcconfig

    r212906 r212927  
    6969LIBWEBRTC_LDFLAGS = $(LIBWEBRTC_LDFLAGS_$(ENABLE_WEB_RTC));
    7070LIBWEBRTC_LDFLAGS_ = ;
    71 LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC = -framework VideoToolbox -framework CoreMedia -framework CoreVideo -weak-lwebrtc;
     71LIBWEBRTC_LDFLAGS_ENABLE_WEB_RTC = -framework VideoToolbox -framework CoreMedia -weak-lwebrtc;
    7272
    7373OTHER_LDFLAGS = $(inherited) $(OTHER_LDFLAGS_PLATFORM)

  • trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp

    r203739 r212927  
    3737SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetDataSize, size_t, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
    3838SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetPixelFormatType, OSType, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
     39SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferGetBaseAddressOfPlane, void *, (CVPixelBufferRef pixelBuffer, size_t planeIndex), (pixelBuffer, planeIndex));
    3940SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferLockBaseAddress, CVReturn, (CVPixelBufferRef pixelBuffer, CVOptionFlags lockFlags), (pixelBuffer, lockFlags))
    4041SOFT_LINK_FUNCTION_FOR_SOURCE(WebCore, CoreVideo, CVPixelBufferUnlockBaseAddress, CVReturn, (CVPixelBufferRef pixelBuffer, CVOptionFlags lockFlags), (pixelBuffer, lockFlags))

  • trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.h

    r203739 r212927  
    4444SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVideo, CVPixelBufferGetPixelFormatType, OSType, (CVPixelBufferRef pixelBuffer), (pixelBuffer))
    4545#define CVPixelBufferGetPixelFormatType softLink_CoreVideo_CVPixelBufferGetPixelFormatType
     46SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVideo, CVPixelBufferGetBaseAddressOfPlane, void *, (CVPixelBufferRef pixelBuffer, size_t planeIndex), (pixelBuffer, planeIndex));
     47#define CVPixelBufferGetBaseAddressOfPlane softLink_CoreVideo_CVPixelBufferGetBaseAddressOfPlane
    4648SOFT_LINK_FUNCTION_FOR_HEADER(WebCore, CoreVideo, CVPixelBufferLockBaseAddress, CVReturn, (CVPixelBufferRef pixelBuffer, CVOptionFlags lockFlags), (pixelBuffer, lockFlags))
    4749#define CVPixelBufferLockBaseAddress softLink_CoreVideo_CVPixelBufferLockBaseAddress

  • trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp

    r212399 r212927  
    3636
    3737#include "CoreMediaSoftLink.h"
     38#include "CoreVideoSoftLink.h"
    3839
    3940namespace WebCore {
Note: See TracChangeset for help on using the changeset viewer.