Changeset 212945 in webkit

Timestamp:

Feb 23, 2017 10:52:02 PM (7 years ago)

Author:

Joseph Pecoraro

Message:

[Resource Timing] Add Experimental Feature Flag
​https://bugs.webkit.org/show_bug.cgi?id=167147

Reviewed by Ryosuke Niwa.

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:

Move ResourceTiming to experimental section.
Disable it for El Capitan due to known issues.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
Put experimental flags in the experimental section.

Websites/webkit.org:

• experimental-features.html:

Test for Resource Timing.

Location:

trunk

Files:

• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/Shared/WebPreferencesDefinitions.h (modified) (5 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/mac/DumpRenderTree.mm (modified) (2 diffs)
• Tools/DumpRenderTree/win/DumpRenderTree.cpp (modified) (2 diffs)
• Websites/webkit.org/ChangeLog (modified) (1 diff)
• Websites/webkit.org/experimental-features.html (modified) (5 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-02-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [Resource Timing] Add Experimental Feature Flag
+        https://bugs.webkit.org/show_bug.cgi?id=167147
+
+        Reviewed by Ryosuke Niwa.
+
+        * Shared/WebPreferencesDefinitions.h:
+        Move ResourceTiming to experimental section.
+        Disable it for El Capitan due to known issues.
+
 2017-02-23  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -241 +241 @@
     macro(ShouldSuppressKeyboardInputDuringProvisionalNavigation, shouldSuppressKeyboardInputDuringProvisionalNavigation, Bool, bool, false, "", "") \
     macro(CSSGridLayoutEnabled, cssGridLayoutEnabled, Bool, bool, true, "CSS Grid", "CSS Grid Layout Module support") \
-    macro(ResourceTimingEnabled, resourceTimingEnabled, Bool, bool, false, "Resource Timing", "Enable ResourceTiming API") \
     \
 
@@ -290 +289 @@
     macro(VisibleDebugOverlayRegions, visibleDebugOverlayRegions, UInt32, uint32_t, 0, "", "")
 
-// Our XCode build system does not currently have any concept of DEVELOPER_MODE.
+// Our Xcode build system does not currently have any concept of DEVELOPER_MODE.
 // Cocoa ports must disable experimental features on release branches for now.
 #if ENABLE(DEVELOPER_MODE) || PLATFORM(COCOA)
@@ -296 +295 @@
 #else
 #define DEFAULT_EXPERIMENTAL_FEATURES_ENABLED false
+#endif
+        
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101200
+// <https://webkit.org/b/168415> El Capitan NetworkLoadTiming values are sometimes jumbled
+#define DEFAULT_RESOURCE_TIMING_ENABLED false
+#else
+#define DEFAULT_RESOURCE_TIMING_ENABLED DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
 #endif
 
@@ -302 +308 @@
 // - You must provide the last two parameters for all experimental features. They
 //   are the text exposed to the user from the WebKit client.
-// - They should be alphabetically ordered by the human readable text.
-// - The default value may be either false (for very unstable features) or
+// - They should be alphabetically ordered by the human readable text (the first string).
+// - The default value may be either false (for unstable features) or
 //   DEFAULT_EXPERIMENTAL_FEATURE_ENABLED (for features that are ready for
 //   wider testing).
@@ -315 +321 @@
     macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "CSS Spring Animations", "CSS Spring Animation prototype") \
     macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Gamepads", "Web Gamepad API support") \
+    macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Input Events", "Enable InputEvents support") \
     macro(LinkPreloadEnabled, linkPreloadEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Link Preload", "Link preload support") \
     macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Modern Media Controls", "Use modern media controls look") \
-    macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Input Events", "Enable InputEvents support") \
-    macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, checkWebRTCAvailability(), "WebRTC", "Enable WebRTC API") \
+    macro(ResourceTimingEnabled, resourceTimingEnabled, Bool, bool, DEFAULT_RESOURCE_TIMING_ENABLED, "Resource Timing", "Enable ResourceTiming API") \
     macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \
-    macro(UserTimingEnabled, userTimingEnabled, Bool, bool, false, "User Timing", "Enable UserTiming API") \
+    macro(UserTimingEnabled, userTimingEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "User Timing", "Enable UserTiming API") \
     macro(WebAnimationsEnabled, webAnimationsEnabled, Bool, bool, false, "Web Animations", "Web Animations prototype") \
     macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "WebGL 2.0", "WebGL 2 prototype") \
+    macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, checkWebRTCAvailability(), "WebRTC", "Enable WebRTC API") \
     \
 

trunk/Tools/ChangeLog

@@ +1 @@
+2017-02-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [Resource Timing] Add Experimental Feature Flag
+        https://bugs.webkit.org/show_bug.cgi?id=167147
+
+        Reviewed by Ryosuke Niwa.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (enableExperimentalFeatures):
+        (resetWebPreferencesToConsistentValues):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (enableExperimentalFeatures):
+        (resetWebPreferencesToConsistentValues):
+        Put experimental flags in the experimental section.
+
 2017-02-23  Beth Dakin  <bdakin@apple.com> + Dan Saunders  <dasau@microsoft.com>
 

trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

@@ -843 +843 @@
     [preferences setModernMediaControlsEnabled:YES];
     // FIXME: InputEvents
+    [preferences setResourceTimingEnabled:YES];
     [preferences setSubtleCryptoEnabled:YES];
     [preferences setUserTimingEnabled:YES];
     [preferences setWebAnimationsEnabled:YES];
     [preferences setWebGL2Enabled:YES];
+    [preferences setPeerConnectionEnabled:YES];
 }
 
@@ -952 +954 @@
     
     [preferences setMediaStreamEnabled:YES];
-    [preferences setPeerConnectionEnabled:YES];
-
-    [preferences setResourceTimingEnabled:YES];
 
     [WebPreferences _clearNetworkLoaderSession];

trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

@@ -775 +775 @@
     // FIXME: SpringTimingFunction
     // FIXME: Gamepads
+    prefsPrivate4->setLinkPreloadEnabled(TRUE);
     // FIXME: ModernMediaControls
     // FIXME: InputEvents
+    prefsPrivate4->setResourceTimingEnabled(TRUE);
     // FIXME: SubtleCrypto
     prefsPrivate4->setUserTimingEnabled(TRUE);
     prefsPrivate4->setWebAnimationsEnabled(TRUE);
     // FIXME: WebGL2
+    // FIXME: WebRTC
 }
 
@@ -879 +882 @@
     prefsPrivate4->setCustomElementsEnabled(TRUE);
     prefsPrivate4->setModernMediaControlsEnabled(FALSE);
-    prefsPrivate4->setResourceTimingEnabled(TRUE);
-    prefsPrivate4->setLinkPreloadEnabled(TRUE);
 
     setAlwaysAcceptCookies(false);

trunk/Websites/webkit.org/ChangeLog

@@ +1 @@
+2017-02-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [Resource Timing] Add Experimental Feature Flag
+        https://bugs.webkit.org/show_bug.cgi?id=167147
+
+        Reviewed by Ryosuke Niwa.
+
+        * experimental-features.html:
+        Test for Resource Timing.
+
 2017-02-23  Alex Christensen  <achristensen@webkit.org>
 

trunk/Websites/webkit.org/experimental-features.html

@@ -74 +74 @@
 }
 
-function testWebGL2() {
-    let canvas = document.createElement("canvas");
-    return canvas.getContext("webgl2");
-}
-
 function testLinkPreload() {
     var link = document.createElement("link");
@@ -86 +81 @@
 function testGamepad() {
     return navigator.getGamepads;
-}
-
-function testWebRTC() {
-    return window.RTCPeerConnection;
 }
 
@@ -112 +103 @@
 }
 
+function testResourceTiming() {
+    return !!window.PerformanceResourceTiming;
+}
+
 function testSubtleCrypto() {
     return window.crypto.subtle;
@@ -117 +112 @@
 
 function testUserTiming() {
-    return window.performance.mark;
+    return !!window.PerformanceMark;
 }
 
 function testWebAnimations() {
     return !!window.Animation;
+}
+
+function testWebGL2() {
+    let canvas = document.createElement("canvas");
+    return canvas.getContext("webgl2");
+}
+
+function testWebRTC() {
+    return window.RTCPeerConnection;
 }
 
@@ -151 +155 @@
         <div class="test" id="InputEvents"><p>HTML Input Events</p></div>
         <div class="test" id="LinkPreload"><p>Link Preload</p></div>
+        <div class="test" id="ResourceTiming"><p>Resource Timing</p></div>
         <div class="test" id="SubtleCrypto"><p>SubtleCrypto</p></div>
         <div class="test" id="VariationFonts"><p>Variation Fonts</p></div>