Changeset 213706 in webkit

Timestamp:

Mar 10, 2017 3:31:56 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168409

Unreviewed.

Add some debugging in the hope of understanding why airplay-button.html fails once a day on bots.

Patch by Antoine Quint <Antoine Quint> on 2017-03-10

Source/WebCore:

• Modules/modern-media-controls/controls/scheduler.js:

(const.scheduler.new.prototype.scheduleLayout):
(const.scheduler.new.prototype.unscheduleLayout):
(const.scheduler.new.prototype._requestFrameIfNeeded):
(const.scheduler.new.prototype._frameDidFire):
(const.scheduler.new.prototype._layout):

LayoutTests:

• media/modern-media-controls/airplay-button/airplay-button-expected.txt:
• media/modern-media-controls/airplay-button/airplay-button.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt (modified) (2 diffs)
• LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/modern-media-controls/controls/scheduler.js (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-03-10  Antoine Quint  <graouts@apple.com>
+
+        [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=168409
+
+        Unreviewed.
+
+        Add some debugging in the hope of understanding why airplay-button.html fails once a day on bots.
+
+        * media/modern-media-controls/airplay-button/airplay-button-expected.txt:
+        * media/modern-media-controls/airplay-button/airplay-button.html:
+
 2017-03-09  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-expected.txt

@@ -4 +4 @@
 
 
+scheduleLayout() - start
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - registered rAF, _frameID = 1
+scheduleLayout() - _layoutCallbacks.size = 1
+scheduleLayout() - end
+scheduleLayout() - start
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - failed to register rAF call, _frameID = 1, _layoutCallbacks.size = 1
+scheduleLayout() - _layoutCallbacks.size = 1
+scheduleLayout() - end
+scheduleLayout() - start
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - failed to register rAF call, _frameID = 1, _layoutCallbacks.size = 1
+scheduleLayout() - _layoutCallbacks.size = 1
+scheduleLayout() - end
 PASS airplayButton.element.localName is "button"
 PASS airplayButton.element.classList.contains("icon") is true
 PASS airplayButton.element.classList.contains("airplay") is true
 PASS airplayButton.iconName is "airplay"
-PASS airplayButton.width is 0
-PASS airplayButton.height is 0
+FAIL airplayButton.width should be 0. Was 25.
+FAIL airplayButton.height should be 0. Was 22.
 PASS airplayButton._image is iconService.imageForIconNameAndLayoutTraits(Icons.Airplay, LayoutTraits.macOS)
 PASS airplayButton._image.src is not ""
-PASS airplayButton._image.complete is false
+FAIL airplayButton._image.complete should be false. Was true.
 PASS airplayButton.width is not 0
 PASS airplayButton.height is not 0
@@ -20 +35 @@
 PASS scheduler._frameID is not -1
 PASS dirtyNodes.has(airplayButton) is true
+_frameDidFire() - start
 frameWillFire()
 PASS dirtyNodes.has(airplayButton) is true
 PASS airplayButton.needsLayout is true
+_layout() - start
+_layout() - layoutCallbacks.size = 1
+_layout() - end
+_requestFrameIfNeeded()
+_requestFrameIfNeeded() - failed to register rAF call, _frameID = -1, _layoutCallbacks.size = 0
 frameDidFire()
 PASS dirtyNodes.has(airplayButton) is false
 PASS airplayButton.needsLayout is false
+_frameDidFire() - end
 PASS airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@") became true
 PASS successfullyParsed is true

trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html

@@ +1 @@
+<meta charset="utf-8">
 <script src="../../../resources/js-test-pre.js"></script>
 <script src="../resources/media-controls-utils.js" type="text/javascript"></script>
@@ -6 +7 @@
 
 window.jsTestIsAsync = true;
+scheduler.debug = debug;
 
 description("Testing the <code>AirplayButton</code> class.");

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-10  Antoine Quint  <graouts@apple.com>
+
+        [mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=168409
+
+        Unreviewed.
+
+        Add some debugging in the hope of understanding why airplay-button.html fails once a day on bots.
+
+        * Modules/modern-media-controls/controls/scheduler.js:
+        (const.scheduler.new.prototype.scheduleLayout):
+        (const.scheduler.new.prototype.unscheduleLayout):
+        (const.scheduler.new.prototype._requestFrameIfNeeded):
+        (const.scheduler.new.prototype._frameDidFire):
+        (const.scheduler.new.prototype._layout):
+
 2017-03-09  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/controls/scheduler.js

@@ -7 +7 @@
         this._frameID = -1;
         this._layoutCallbacks = new Set;
+        this.debug = new Function;
     }
 
@@ -18 +19 @@
     scheduleLayout(callback)
     {
-        if (typeof callback !== "function")
+        this.debug("scheduleLayout() - start");
+        if (typeof callback !== "function") {
+            this.debug("scheduleLayout() - end - callback was not a function");
             return;
+        }
 
         this._layoutCallbacks.add(callback);
         this._requestFrameIfNeeded();
+        this.debug(`scheduleLayout() - _layoutCallbacks.size = ${this._layoutCallbacks.size}`);
+        this.debug("scheduleLayout() - end");
     }
 
     unscheduleLayout(callback)
     {
-        if (typeof callback !== "function")
+        this.debug("unscheduleLayout() - start");
+        if (typeof callback !== "function") {
+            this.debug("unscheduleLayout() - end - callback was not a function");
             return;
+        }
 
         this._layoutCallbacks.delete(callback);
+        this.debug(`unscheduleLayout() - this._layoutCallbacks.size = ${this._layoutCallbacks.size}`);
+        this.debug("unscheduleLayout() - end");
     }
 
@@ -37 +48 @@
     _requestFrameIfNeeded()
     {
-        if (this._frameID === -1 && this._layoutCallbacks.size > 0)
+        this.debug("_requestFrameIfNeeded()");
+        if (this._frameID === -1 && this._layoutCallbacks.size > 0) {
             this._frameID = window.requestAnimationFrame(this._frameDidFire.bind(this));
+            this.debug(`_requestFrameIfNeeded() - registered rAF, _frameID = ${this._frameID}`);
+        } else
+            this.debug(`_requestFrameIfNeeded() - failed to register rAF call, _frameID = ${this._frameID}, _layoutCallbacks.size = ${this._layoutCallbacks.size}`);
     }
 
     _frameDidFire()
     {
+        this.debug("_frameDidFire() - start");
         if (typeof scheduler.frameWillFire === "function")
             scheduler.frameWillFire();
@@ -52 +68 @@
         if (typeof scheduler.frameDidFire === "function")
             scheduler.frameDidFire();
+        this.debug("_frameDidFire() - end");
     }
 
     _layout()
     {
+        this.debug("_layout() - start");
         // Layouts are not re-entrant.
         const layoutCallbacks = this._layoutCallbacks;
         this._layoutCallbacks = new Set;
 
+        this.debug(`_layout() - layoutCallbacks.size = ${layoutCallbacks.size}`);
+
         for (let callback of layoutCallbacks)
             callback();
+        this.debug("_layout() - end");
     }