Changeset 213744 in webkit

Timestamp:

Mar 10, 2017 5:56:08 PM (7 years ago)

Author:

Matt Baker

Message:

Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=169488

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/DOMBreakpointTreeController.js:

(WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
Added assert to catch future cases where UI is being added when
backend support doesn't exist.

• UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
Check for backend support.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DOMBreakpointTreeController.js (modified) (1 diff)
• UserInterface/Views/DOMTreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-03-10  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
+        https://bugs.webkit.org/show_bug.cgi?id=169488
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Controllers/DOMBreakpointTreeController.js:
+        (WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
+        Added assert to catch future cases where UI is being added when
+        backend support doesn't exist.
+
+        * UserInterface/Views/DOMTreeElement.js:
+        (WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
+        Check for backend support.
+
 2017-03-10  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js

@@ -45 +45 @@
     static appendBreakpointContextMenuItems(contextMenu, domNode, allowEditing)
     {
+        console.assert(WebInspector.domDebuggerManager.supported);
+
         let subMenu = contextMenu.appendSubMenuItem(WebInspector.UIString("Break on…"));
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

@@ -761 +761 @@
         }
 
-        if (node.nodeType() === Node.ELEMENT_NODE) {
+        if (WebInspector.domDebuggerManager.supported && node.nodeType() === Node.ELEMENT_NODE) {
             contextMenu.appendSeparator();