Changeset 21409 in webkit
- Timestamp:
- May 11, 2007 9:45:45 AM (17 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/JavaScriptCore/ChangeLog
r21406 r21409 1 2007-05-11 Kimmo Kinnunen <kimmok@iki.fi> 2 3 Reviewed by Darin. 4 5 - Fix for bug http://bugs.webkit.org/show_bug.cgi?id=13620 6 Bogus decompilation of "for (var j = 1 in [])" 7 - ForInNode toString()'ed to syntax error if there was var decl 8 and initializer 9 - ForNode toStringed()'ed lost 'var ' if it was present 10 11 * kjs/nodes2string.cpp: 12 (VarDeclListNode::streamTo): Print "var " here 13 (VarStatementNode::streamTo): Don't print "var " here 14 (ForNode::streamTo): Remove TODO comment, VarDeclListNode will 15 stream the "var " 16 (ForInNode::streamTo): ForIn initializer is printed by VarDeclNode 17 1 18 2007-05-11 Kimmo Kinnunen <kimmok@iki.fi> 2 19 -
trunk/JavaScriptCore/kjs/nodes2string.cpp
r21406 r21409 594 594 void VarDeclListNode::streamTo(SourceStream &s) const 595 595 { 596 s << var;596 s << "var " << var; 597 597 for (VarDeclListNode *n = next.get(); n; n = n->next.get()) 598 598 s << ", " << n->var; … … 601 601 void VarStatementNode::streamTo(SourceStream &s) const 602 602 { 603 s << SourceStream::Endl << "var " <<next << ";";603 s << SourceStream::Endl << next << ";"; 604 604 } 605 605 … … 645 645 { 646 646 s << SourceStream::Endl << "for (" 647 << expr1 // TODO: doesn't properly do "var i = 0"647 << expr1 648 648 << "; " << expr2 649 649 << "; " << expr3 … … 658 658 else 659 659 s << lexpr; 660 661 if (init) 662 s << " = " << init; 660 663 661 s << " in " << expr << ")" << SourceStream::Indent 664 662 << statement << SourceStream::Unindent; -
trunk/LayoutTests/ChangeLog
r21407 r21409 1 2007-05-11 Kimmo Kinnunen <kimmok@iki.fi> 2 3 Reviewed by Darin. 4 5 - Tests for bug http://bugs.webkit.org/show_bug.cgi?id=13620 6 Bogus decompilation of "for (var j = 1 in [])" 7 8 Testcase covers toString()ing functions with 9 for-statements of form for (var j = 1 in []) and for (var j=0;j<10;j++) 10 11 * fast/js/resources/toString-for-var-decl.js: Added. 12 * fast/js/toString-for-var-decl-expected.txt: Added. 13 * fast/js/toString-for-var-decl.html: Added. 14 1 15 2007-05-11 Kimmo Kinnunen <kimmok@iki.fi> 2 16
Note: See TracChangeset
for help on using the changeset viewer.