Changeset 214272 in webkit

Timestamp:

Mar 22, 2017 1:07:21 PM (7 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Use jsNontrivialString for Number toString operations
​https://bugs.webkit.org/show_bug.cgi?id=169965

Reviewed by Mark Lam.

JSTests:

• stress/to-string-int32.js: Added.

(shouldBe):
(toString10):
(expected):

Source/JavaScriptCore:

After single character check, produced string is always longer than 1.
Thus, we can use jsNontrivialString.

• runtime/NumberPrototype.cpp:

(JSC::int32ToStringInternal):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/to-string-int32.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/NumberPrototype.cpp (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2017-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] Use jsNontrivialString for Number toString operations
+        https://bugs.webkit.org/show_bug.cgi?id=169965
+
+        Reviewed by Mark Lam.
+
+        * stress/to-string-int32.js: Added.
+        (shouldBe):
+        (toString10):
+        (expected):
+
 2017-03-22  JF Bastien  <jfbastien@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] Use jsNontrivialString for Number toString operations
+        https://bugs.webkit.org/show_bug.cgi?id=169965
+
+        Reviewed by Mark Lam.
+
+        After single character check, produced string is always longer than 1.
+        Thus, we can use jsNontrivialString.
+
+        * runtime/NumberPrototype.cpp:
+        (JSC::int32ToStringInternal):
+
 2017-03-22  JF Bastien  <jfbastien@apple.com>
 

trunk/Source/JavaScriptCore/runtime/NumberPrototype.cpp

@@ -500 +500 @@
 }
 
-static inline JSString* int32ToStringInternal(VM& vm, int32_t value, int32_t radix)
+static ALWAYS_INLINE JSString* int32ToStringInternal(VM& vm, int32_t value, int32_t radix)
 {
     ASSERT(!(radix < 2 || radix > 36));
@@ -510 +510 @@
     }
 
-    if (radix == 10) {
-        return jsString(&vm, vm.numericStrings.add(value));
-    }
-
-    return jsString(&vm, toStringWithRadix(value, radix));
+    if (radix == 10)
+        return jsNontrivialString(&vm, vm.numericStrings.add(value));
+
+    return jsNontrivialString(&vm, toStringWithRadix(value, radix));
 
 }