Changeset 214501 in webkit

Timestamp:

Mar 28, 2017 3:48:26 PM (7 years ago)

Author:

Antti Koivisto

Message:

Missing render tree position invalidation when tearing down renderers for display:contents subtree
​https://bugs.webkit.org/show_bug.cgi?id=170199
<rdar://problem/31260856>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/shadow-dom/slot-renderer-teardown.html

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):

Invalidate the render tree position in case we do a teardown for an element without renderer.

LayoutTests:

• fast/shadow-dom/slot-renderer-teardown-expected.txt: Added.
• fast/shadow-dom/slot-renderer-teardown.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/shadow-dom/slot-renderer-teardown-expected.txt (added)
• LayoutTests/fast/shadow-dom/slot-renderer-teardown.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/style/RenderTreeUpdater.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-03-28  Antti Koivisto  <antti@apple.com>
+
+        Missing render tree position invalidation when tearing down renderers for display:contents subtree
+        https://bugs.webkit.org/show_bug.cgi?id=170199
+        <rdar://problem/31260856>
+
+        Reviewed by Zalan Bujtas.
+
+        * fast/shadow-dom/slot-renderer-teardown-expected.txt: Added.
+        * fast/shadow-dom/slot-renderer-teardown.html: Added.
+
 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-28  Antti Koivisto  <antti@apple.com>
+
+        Missing render tree position invalidation when tearing down renderers for display:contents subtree
+        https://bugs.webkit.org/show_bug.cgi?id=170199
+        <rdar://problem/31260856>
+
+        Reviewed by Zalan Bujtas.
+
+        Test: fast/shadow-dom/slot-renderer-teardown.html
+
+        * style/RenderTreeUpdater.cpp:
+        (WebCore::RenderTreeUpdater::updateElementRenderer):
+
+            Invalidate the render tree position in case we do a teardown for an element without renderer.
+
 2017-03-28  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/style/RenderTreeUpdater.cpp

@@ -260 +260 @@
     bool shouldTearDownRenderers = update.change == Style::Detach
         && (element.renderer() || element.isNamedFlowContentElement() || element.hasDisplayContents());
-    if (shouldTearDownRenderers)
+    if (shouldTearDownRenderers) {
+        if (!element.renderer()) {
+            // We may be tearing down a descendant renderer cached in renderTreePosition.
+            renderTreePosition().invalidateNextSibling();
+        }
         tearDownRenderers(element, TeardownType::KeepHoverAndActive);
+    }
 
     bool hasDisplayContents = update.style->display() == CONTENTS;