Changeset 214666 in webkit

Timestamp:

Mar 31, 2017 6:37:33 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

Modern media controls should never be enabled in non cocoa ports
​https://bugs.webkit.org/show_bug.cgi?id=170338

Reviewed by Michael Catanzaro.

It's currently enabled, because it uses the default value for all other runtime features, but modern media
controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html
started to fail in GTK+ port after r214426. I can't reprouduce the failure locally, so I can't confirm it,
though.

• Shared/WebPreferencesDefinitions.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferencesDefinitions.h (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Modern media controls should never be enabled in non cocoa ports
+        https://bugs.webkit.org/show_bug.cgi?id=170338
+
+        Reviewed by Michael Catanzaro.
+
+        It's currently enabled, because it uses the default value for all other runtime features, but modern media
+        controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html
+        started to fail in GTK+ port after r214426. I can't reprouduce the failure locally, so I can't confirm it,
+        though.
+
+        * Shared/WebPreferencesDefinitions.h:
+
 2017-03-30  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -317 +317 @@
 #endif
 
+#if PLATFORM(COCOA)
+#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED true
+#else
+#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED false
+#endif
+
 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101200
 // <https://webkit.org/b/168415> El Capitan NetworkLoadTiming values are sometimes jumbled
@@ -336 +342 @@
     macro(SpringTimingFunctionEnabled, springTimingFunctionEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "CSS Spring Animations", "CSS Spring Animation prototype") \
     macro(LinkPreloadEnabled, linkPreloadEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Link Preload", "Link preload support") \
-    macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Modern Media Controls", "Use modern media controls look") \
+    macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED, "Modern Media Controls", "Use modern media controls look") \
     macro(ResourceTimingEnabled, resourceTimingEnabled, Bool, bool, DEFAULT_RESOURCE_TIMING_ENABLED, "Resource Timing", "Enable ResourceTiming API") \
     macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \