Changeset 214766 in webkit
- Timestamp:
- Apr 3, 2017 4:03:11 AM (7 years ago)
- Location:
- releases/WebKitGTK/webkit-2.16
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
r214764 r214766 1 2017-03-17 Dave Hyatt <hyatt@apple.com> 2 3 Disable per-region boxes for multicolumn 4 https://bugs.webkit.org/show_bug.cgi?id=169830 5 6 Reviewed by Zalan Bujtas. 7 8 * fast/multicol/float-adjacent-to-overflow-block-expected.html: Added. 9 * fast/multicol/float-adjacent-to-overflow-block.html: Added. 10 1 11 2017-03-17 Zalan Bujtas <zalan@apple.com> 2 12 -
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
r214765 r214766 1 2017-03-17 Dave Hyatt <hyatt@apple.com> 2 3 Disable per-region boxes for multicolumn 4 https://bugs.webkit.org/show_bug.cgi?id=169830 5 6 Reviewed by Zalan Bujtas. 7 8 Test: fast/multicol/float-adjacent-to-overflow-block.html 9 10 * rendering/RenderBlockFlow.cpp: 11 (WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild): 12 * rendering/RenderBox.cpp: 13 (WebCore::RenderBox::borderBoxRectInRegion): 14 (WebCore::RenderBox::renderBoxRegionInfo): 15 Limit all of the per-region box code to RenderNamedFlowThreads. 16 This code should never be used by multicolumn layout. 17 1 18 2017-03-17 Said Abou-Hallawa <sabouhallawa@apple.com> 2 19 -
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderBlockFlow.cpp
r214761 r214766 37 37 #include "Logging.h" 38 38 #include "RenderCombineText.h" 39 #include "RenderFlowThread.h"40 39 #include "RenderInline.h" 41 40 #include "RenderIterator.h" … … 47 46 #include "RenderMultiColumnSet.h" 48 47 #include "RenderNamedFlowFragment.h" 48 #include "RenderNamedFlowThread.h" 49 49 #include "RenderTableCell.h" 50 50 #include "RenderText.h" … … 877 877 // Some objects (e.g., tables, horizontal rules, overflow:auto blocks) avoid floats. They need 878 878 // to shift over as necessary to dodge any floats that might get in the way. 879 if (child.avoidsFloats() && containsFloats() && ! flowThreadContainingBlock())879 if (child.avoidsFloats() && containsFloats() && !is<RenderNamedFlowThread>(flowThreadContainingBlock())) 880 880 newPosition += computeStartPositionDeltaForChildAvoidingFloats(child, marginStartForChild(child)); 881 881 -
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderBox.cpp
r214761 r214766 211 211 return borderBoxRect(); 212 212 213 RenderFlowThread* flowThread = flowThreadContainingBlock();214 if (! flowThread)213 auto* flowThread = flowThreadContainingBlock(); 214 if (!is<RenderNamedFlowThread>(flowThread)) 215 215 return borderBoxRect(); 216 216 … … 2711 2711 // support to cover all boxes. 2712 2712 RenderFlowThread* flowThread = flowThreadContainingBlock(); 2713 if (isRenderFlowThread() || ! flowThread|| !canHaveBoxInfoInRegion() || flowThread->style().writingMode() != style().writingMode())2713 if (isRenderFlowThread() || !is<RenderNamedFlowThread>(flowThread) || !canHaveBoxInfoInRegion() || flowThread->style().writingMode() != style().writingMode()) 2714 2714 return nullptr; 2715 2715
Note: See TracChangeset
for help on using the changeset viewer.