Changeset 214796 in webkit

Timestamp:

Apr 3, 2017 8:58:46 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r214340 - Text stroke is sometimes clipped on video captions.
​https://bugs.webkit.org/show_bug.cgi?id=170006

Reviewed by Eric Carlson.

Source/WebCore:

Set 'overflow' property to 'visible' on cue element to avoid clipping of text stroke.

Updated test media/track/track-css-stroke-cues.html.

• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

• html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

LayoutTests:

• media/track/track-css-stroke-cues-expected.txt:
• media/track/track-css-stroke-cues.html:

Location:

releases/WebKitGTK/webkit-2.16

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/track/track-css-stroke-cues-expected.txt (modified) (1 diff)
• LayoutTests/media/track/track-css-stroke-cues.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/track/TextTrackCueGeneric.cpp (modified) (1 diff)
• Source/WebCore/html/track/VTTCue.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog

@@ +1 @@
+2017-03-24  Per Arne Vollan  <pvollan@apple.com>
+
+        Text stroke is sometimes clipped on video captions.
+        https://bugs.webkit.org/show_bug.cgi?id=170006
+
+        Reviewed by Eric Carlson.
+
+        * media/track/track-css-stroke-cues-expected.txt:
+        * media/track/track-css-stroke-cues.html:
+
 2017-03-23  Brady Eidson  <beidson@apple.com>
 

releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues-expected.txt

@@ -8 +8 @@
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinejoin == 'round') OK
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinecap == 'round') OK
+EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).overflow == 'visible') OK
 END OF TEST
 

releases/WebKitGTK/webkit-2.16/LayoutTests/media/track/track-css-stroke-cues.html

@@ -23 +23 @@
             testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinejoin", "round");
             testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinecap", "round");
+            testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).overflow", "visible");
             endTest();
         }

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-24  Per Arne Vollan  <pvollan@apple.com>
+
+        Text stroke is sometimes clipped on video captions.
+        https://bugs.webkit.org/show_bug.cgi?id=170006
+
+        Reviewed by Eric Carlson.
+
+        Set 'overflow' property to 'visible' on cue element to avoid clipping of text stroke.
+
+        Updated test media/track/track-css-stroke-cues.html.
+
+        * html/track/TextTrackCueGeneric.cpp:
+        (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
+        * html/track/VTTCue.cpp:
+        (WebCore::VTTCueBox::applyCSSProperties):
+
 2017-03-23  Brady Eidson  <beidson@apple.com>
 

releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/TextTrackCueGeneric.cpp

@@ -142 +142 @@
     setInlineStyleProperty(CSSPropertyWritingMode, cue->getCSSWritingMode(), false);
     setInlineStyleProperty(CSSPropertyWhiteSpace, CSSValuePreWrap);
+
+    // Make sure shadow or stroke is not clipped.
+    setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
+    cueElement->setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
 }
 

releases/WebKitGTK/webkit-2.16/Source/WebCore/html/track/VTTCue.cpp

@@ -224 +224 @@
         setInlineStyleProperty(CSSPropertyWhiteSpace, CSSValuePre);
     }
+
+    // Make sure shadow or stroke is not clipped.
+    setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
+    m_cue.element().setInlineStyleProperty(CSSPropertyOverflow, CSSValueVisible);
 }