Changeset 214813 in webkit

Timestamp:

Apr 3, 2017 10:23:43 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r214666 - Modern media controls should never be enabled in non cocoa ports
​https://bugs.webkit.org/show_bug.cgi?id=170338

Reviewed by Michael Catanzaro.

It's currently enabled, because it uses the default value for all other runtime features, but modern media
controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html
started to fail in GTK+ port after r214426. I can't reprouduce the failure locally, so I can't confirm it,
though.

• Shared/WebPreferencesDefinitions.h:

Location:

releases/WebKitGTK/webkit-2.16/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferencesDefinitions.h (modified) (2 diffs)

releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Modern media controls should never be enabled in non cocoa ports
+        https://bugs.webkit.org/show_bug.cgi?id=170338
+
+        Reviewed by Michael Catanzaro.
+
+        It's currently enabled, because it uses the default value for all other runtime features, but modern media
+        controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html
+        started to fail in GTK+ port after r214426. I can't reprouduce the failure locally, so I can't confirm it,
+        though.
+
+        * Shared/WebPreferencesDefinitions.h:
+
 2017-04-03  Antti Koivisto  <antti@apple.com>
 

releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -297 +297 @@
 #endif
 
+#if PLATFORM(COCOA)
+#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED true
+#else
+#define DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED false
+#endif
+
 // For experimental features:
 // - The type should be boolean.
@@ -310 +316 @@
     macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Gamepads", "Web Gamepad API support") \
     macro(LinkPreloadEnabled, linkPreloadEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Link Preload", "Link preload support") \
-    macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Modern Media Controls", "Use modern media controls look") \
+    macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED, "Modern Media Controls", "Use modern media controls look") \
     macro(InputEventsEnabled, inputEventsEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "Input Events", "Enable InputEvents support") \
     macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, false, "WebRTC", "Enable WebRTC API") \