Changeset 214826 in webkit

Timestamp:

Apr 3, 2017 11:44:05 AM (7 years ago)

Author:

keith_miller@apple.com

Message:

WebAssembly: remove lastAllocatedMode from Memory
​https://bugs.webkit.org/show_bug.cgi?id=170405

Reviewed by Mark Lam.

It's not used anymore so there isn't any point in keeping it around.

• wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::lastAllocatedMode): Deleted.

• wasm/WasmMemory.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wasm/WasmMemory.cpp (modified) (3 diffs)
• wasm/WasmMemory.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-04-03  Keith Miller  <keith_miller@apple.com>
+
+        WebAssembly: remove lastAllocatedMode from Memory
+        https://bugs.webkit.org/show_bug.cgi?id=170405
+
+        Reviewed by Mark Lam.
+
+        It's not used anymore so there isn't any point in keeping it around.
+
+        * wasm/WasmMemory.cpp:
+        (JSC::Wasm::Memory::createImpl):
+        (JSC::Wasm::Memory::lastAllocatedMode): Deleted.
+        * wasm/WasmMemory.h:
+
 2017-04-03  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/JavaScriptCore/wasm/WasmMemory.cpp

@@ -74 +74 @@
 }
 
-// We use this as a heuristic to guess what mode a memory import will be. Most of the time we expect users to
-// allocate the memory they are going to pass to all their modules right before compilation.
-static MemoryMode lastAllocatedMemoryMode { MemoryMode::Signaling };
-
-MemoryMode Memory::lastAllocatedMode()
-{
-    return lastAllocatedMemoryMode;
-}
-
 static const unsigned maxFastMemories = 4;
 static unsigned allocatedFastMemories { 0 };
@@ -217 +208 @@
             return nullptr;
 
-        lastAllocatedMemoryMode = MemoryMode::BoundsChecking;
         return adoptRef(new Memory(initial, maximum));
     };
@@ -261 +251 @@
     }
 
-    lastAllocatedMemoryMode = mode;
     dataLogLnIf(verbose, "Memory::create mmap succeeded");
     return adoptRef(new Memory(memory, initial, maximum, mappedCapacity, mode));

trunk/Source/JavaScriptCore/wasm/WasmMemory.h

@@ -74 +74 @@
     PageCount maximum() const { return m_maximum; }
 
-    static MemoryMode lastAllocatedMode();
     MemoryMode mode() const { return m_mode; }