Changeset 214831 in webkit

Timestamp:

Apr 3, 2017 12:35:26 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Do not set WebAVPlayerLayerView background to black in fullscreen.
​https://bugs.webkit.org/show_bug.cgi?id=170132
rdar://problem/30839278

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-04-03
Reviewed by Tim Horton.

No new tests because no behavior change.

The black background on WebAVPlayerLayerView interferes with the fullscreen animation
and has been removed.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-03  Jeremy Jones  <jeremyj@apple.com>
+
+        Do not set WebAVPlayerLayerView background to black in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=170132
+        rdar://problem/30839278
+
+        Reviewed by Tim Horton.
+
+        No new tests because no behavior change.
+
+        The black background on WebAVPlayerLayerView interferes with the fullscreen animation
+        and has been removed.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::enterFullscreen):
+        (WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard):
+
 2017-04-03  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -669 +669 @@
     m_enterRequested = true;
 
-    [m_playerLayerView setBackgroundColor:[getUIColorClass() blackColor]];
     if (mode() == HTMLMediaElementEnums::VideoFullscreenModePictureInPicture)
         enterPictureInPicture();
@@ -700 +699 @@
     }
 
-    [m_playerLayerView setBackgroundColor:[getUIColorClass() blackColor]];
     [m_playerViewController enterFullScreenAnimated:YES completionHandler:[this, protectedThis] (BOOL succeeded, NSError*) {
         UNUSED_PARAM(succeeded);