Changeset 214840 in webkit

Timestamp:

Apr 3, 2017 3:05:04 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Tooltip for close tab button should match Safari
​https://bugs.webkit.org/show_bug.cgi?id=170417
<rdar://problem/31378423>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-03
Reviewed by Matt Baker.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/GeneralTabBarItem.js:

(WebInspector.GeneralTabBarItem):
Updated tooltip to match Safari's most descriptive tooltip.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Views/GeneralTabBarItem.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-04-03  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Tooltip for close tab button should match Safari
+        https://bugs.webkit.org/show_bug.cgi?id=170417
+        <rdar://problem/31378423>
+
+        Reviewed by Matt Baker.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/GeneralTabBarItem.js:
+        (WebInspector.GeneralTabBarItem):
+        Updated tooltip to match Safari's most descriptive tooltip.
+
 2017-04-03  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -168 +168 @@
 localizedStrings["Clear when page navigates"] = "Clear when page navigates";
 localizedStrings["Click Listener"] = "Click Listener";
+localizedStrings["Click to close this tab; Option-click to close all tabs except this one"] = "Click to close this tab; Option-click to close all tabs except this one";
 localizedStrings["Click to link property values"] = "Click to link property values";
 localizedStrings["Click to select a color. Shift-click to switch color formats."] = "Click to select a color. Shift-click to switch color formats.";
@@ -177 +178 @@
 localizedStrings["Close Tab"] = "Close Tab";
 localizedStrings["Close resource view"] = "Close resource view";
-localizedStrings["Close tab"] = "Close tab";
 localizedStrings["Closed"] = "Closed";
 localizedStrings["Closure Variables"] = "Closure Variables";

trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTabBarItem.js

@@ -33 +33 @@
         let closeButtonElement = document.createElement("div");
         closeButtonElement.classList.add(WebInspector.TabBarItem.CloseButtonStyleClassName);
-        closeButtonElement.title = WebInspector.UIString("Close tab");
+        closeButtonElement.title = WebInspector.UIString("Click to close this tab; Option-click to close all tabs except this one");
         this.element.insertBefore(closeButtonElement, this.element.firstChild);