Changeset 214842 in webkit

Timestamp:

Apr 3, 2017 3:06:51 PM (7 years ago)

Author:

Chris Dumez

Message:

REGRESSION (r206744): CSS background-image in style attribute ignored when using createHTMLDocument method of DOM parsing
​https://bugs.webkit.org/show_bug.cgi?id=170285
<rdar://problem/31378543>

Reviewed by Andy Estes.

Source/WebCore:

r206744 caused up to stop trying to resolve relative URLs when trying to load an image
referred to by CSS. We already try to resolve the relative URL when parsing the CSS
property so this will usually work fine. However, in the case when the CSS property
is parsed in detached document and then moved to another document, we will not have
the complete URL.

Test: fast/images/background-image-relative-url-changes-document.html

• css/CSSImageValue.cpp:

(WebCore::CSSImageValue::loadImage):

LayoutTests:

Add layout test coverage.

• fast/images/background-image-relative-url-changes-document-expected.html: Added.
• fast/images/background-image-relative-url-changes-document.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/images/background-image-relative-url-changes-document-expected.html (added)
• LayoutTests/fast/images/background-image-relative-url-changes-document.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSImageValue.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-04-03  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r206744): CSS background-image in style attribute ignored when using createHTMLDocument method of DOM parsing
+        https://bugs.webkit.org/show_bug.cgi?id=170285
+        <rdar://problem/31378543>
+
+        Reviewed by Andy Estes.
+
+        Add layout test coverage.
+
+        * fast/images/background-image-relative-url-changes-document-expected.html: Added.
+        * fast/images/background-image-relative-url-changes-document.html: Added.
+
 2017-04-03  John Wilander  <wilander@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-03  Chris Dumez  <cdumez@apple.com>
+
+        REGRESSION (r206744): CSS background-image in style attribute ignored when using createHTMLDocument method of DOM parsing
+        https://bugs.webkit.org/show_bug.cgi?id=170285
+        <rdar://problem/31378543>
+
+        Reviewed by Andy Estes.
+
+        r206744 caused up to stop trying to resolve relative URLs when trying to load an image
+        referred to by CSS. We already try to resolve the relative URL when parsing the CSS
+        property so this will usually work fine. However, in the case when the CSS property
+        is parsed in detached document and then moved to another document, we will not have
+        the complete URL.
+
+        Test: fast/images/background-image-relative-url-changes-document.html
+
+        * css/CSSImageValue.cpp:
+        (WebCore::CSSImageValue::loadImage):
+
 2017-04-03  Jeremy Jones  <jeremyj@apple.com>
 

trunk/Source/WebCore/css/CSSImageValue.cpp

@@ -67 +67 @@
         m_accessedImage = true;
 
-        CachedResourceRequest request(ResourceRequest(m_url), options);
+        CachedResourceRequest request(ResourceRequest(loader.document()->completeURL(m_url.string())), options);
         if (m_initiatorName.isEmpty())
             request.setInitiator(cachedResourceRequestInitiators().css);