Changeset 214853 in webkit

Timestamp:

Apr 3, 2017 4:11:25 PM (7 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown
​https://bugs.webkit.org/show_bug.cgi?id=169649
<rdar://problem/31053069>

Reviewed by Brian Burg.

• UserInterface/Models/WebSocketResource.js:

(WebInspector.WebSocketResource.prototype.addFrame):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/WebSocketResource.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-04-03  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown
+        https://bugs.webkit.org/show_bug.cgi?id=169649
+        <rdar://problem/31053069>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Models/WebSocketResource.js:
+        (WebInspector.WebSocketResource.prototype.addFrame):
+
 2017-04-03  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js

@@ -62 +62 @@
     addFrame(data, isOutgoing, opcode, timestamp, elapsedTime)
     {
-        let frame = {data, isOutgoing, opcode, walltime: this._walltimeForWebSocketTimestamp(timestamp)};
+        let frameData;
+
+        // Binary data is never shown in the UI, don't clog memory with it.
+        if (opcode === WebInspector.WebSocketResource.OpCodes.BinaryFrame)
+            frameData = null;
+        else
+            frameData = data;
+
+        let frame = {data: frameData, isOutgoing, opcode, walltime: this._walltimeForWebSocketTimestamp(timestamp)};
         this._frames.push(frame);