Changeset 215366 in webkit

Timestamp:

Apr 14, 2017 10:57:26 AM (7 years ago)

Author:

mmaxfield@apple.com

Message:

Add performance test for asking the platform for a font for U+2060 WORD JOINER
​https://bugs.webkit.org/show_bug.cgi?id=170842

Reviewed by Tim Horton.

PerformanceTests:

• Layout/word-joiner.html: Added.

Source/WebCore:

No new tests because there is no behavior change.

• platform/graphics/WidthCache.h:

(WebCore::WidthCache::add):
(WebCore::WidthCache::addSlowCase):

Source/WTF:

• wtf/unicode/CharacterNames.h:

Location:

trunk

Files:

• PerformanceTests/ChangeLog (modified) (1 diff)
• PerformanceTests/Layout/word-joiner.html (added)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/unicode/CharacterNames.h (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/WidthCache.h (modified) (2 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2017-04-14  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Add performance test for asking the platform for a font for U+2060 WORD JOINER
+        https://bugs.webkit.org/show_bug.cgi?id=170842
+
+        Reviewed by Tim Horton.
+
+        * Layout/word-joiner.html: Added.
+
 2017-04-03  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2017-04-14  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Add performance test for asking the platform for a font for U+2060 WORD JOINER
+        https://bugs.webkit.org/show_bug.cgi?id=170842
+
+        Reviewed by Tim Horton.
+
+        * wtf/unicode/CharacterNames.h:
+
 2017-04-13  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/WTF/wtf/unicode/CharacterNames.h

@@ -93 +93 @@
 const UChar whiteSesameDot = 0xFE46;
 const UChar whiteUpPointingTriangle = 0x25B3;
+const UChar wordJoiner = 0x2060;
 const UChar yenSign = 0x00A5;
 const UChar zeroWidthJoiner = 0x200D;
@@ -155 +156 @@
 using WTF::Unicode::whiteSesameDot;
 using WTF::Unicode::whiteUpPointingTriangle;
+using WTF::Unicode::wordJoiner;
 using WTF::Unicode::yenSign;
 using WTF::Unicode::zeroWidthJoiner;

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-04-14  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Add performance test for asking the platform for a font for U+2060 WORD JOINER
+        https://bugs.webkit.org/show_bug.cgi?id=170842
+
+        Reviewed by Tim Horton.
+
+        No new tests because there is no behavior change.
+
+        * platform/graphics/WidthCache.h:
+        (WebCore::WidthCache::add):
+        (WebCore::WidthCache::addSlowCase):
+
 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/platform/graphics/WidthCache.h

@@ -141 +141 @@
         // The width cache is not really profitable unless we're doing expensive glyph transformations.
         if (!hasKerningOrLigatures)
-            return 0;
+            return nullptr;
         // Word spacing and letter spacing can change the width of a word.
         if (hasWordSpacingOrLetterSpacing)
-            return 0;
+            return nullptr;
         // Since this is just a width cache, we don't have enough information to satisfy glyph queries.
         if (glyphOverflow)
-            return 0;
+            return nullptr;
         // If we allow tabs and a tab occurs inside a word, the width of the word varies based on its position on the line.
         if (run.allowTabs())
-            return 0;
+            return nullptr;
         if (static_cast<unsigned>(run.length()) > SmallStringKey::capacity())
-            return 0;
+            return nullptr;
 
         if (m_countdown > 0) {
             --m_countdown;
-            return 0;
+            return nullptr;
         }
 
@@ -208 +208 @@
         m_singleCharMap.clear();
         m_map.clear();
-        return 0;
+        return nullptr;
     }