Changeset 215618 in webkit

Timestamp:

Apr 21, 2017, 11:28:51 AM (9 years ago)

Author:

msaboff@apple.com

Message:

X86-64 Assembler doesn't handle xchg with byte register src
​https://bugs.webkit.org/show_bug.cgi?id=171118

Reviewed by Saam Barati.

• assembler/X86Assembler.h:

(JSC::X86Assembler::xchgb_rm): Use oneByteOp8() since these are 8 bit opcodes.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/X86Assembler.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-04-21  Michael Saboff  <msaboff@apple.com>
+
+        X86-64 Assembler doesn't handle xchg with byte register src
+        https://bugs.webkit.org/show_bug.cgi?id=171118
+
+        Reviewed by Saam Barati.
+
+        * assembler/X86Assembler.h:
+        (JSC::X86Assembler::xchgb_rm): Use oneByteOp8() since these are 8 bit opcodes.
+
 2017-04-21  Andy VanWagoner  <thetalecrafter@gmail.com>
 

trunk/Source/JavaScriptCore/assembler/X86Assembler.h

@@ -2157 +2157 @@
     void xchgb_rm(RegisterID src, int offset, RegisterID base)
     {
-        m_formatter.oneByteOp(OP_XCHG_EvGb, src, base, offset);
+        m_formatter.oneByteOp8(OP_XCHG_EvGb, src, base, offset);
     }
 
     void xchgb_rm(RegisterID src, int offset, RegisterID base, RegisterID index, int scale)
     {
-        m_formatter.oneByteOp(OP_XCHG_EvGb, src, base, index, scale, offset);
+        m_formatter.oneByteOp8(OP_XCHG_EvGb, src, base, index, scale, offset);
     }