Changeset 215884 in webkit


Ignore:
Timestamp:
Apr 27, 2017 12:08:22 PM (7 years ago)
Author:
mmaxfield@apple.com
Message:

REGRESSION(r214572): Update fast/text/variations/advances.html to understand normalized variation widths
​https://bugs.webkit.org/show_bug.cgi?id=171356
<rdar://problem/28670085>

Reviewed by Dean Jackson.

Unspecified 'wdth' axis values are being normalized because the font is a GX font. However, this
font assumes no normalization, which means one of the comparisons in the test is bogus.

  • fast/text/variations/advances-expected.txt:
  • fast/text/variations/advances.html:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r215882 r215884  
     12017-04-27  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        REGRESSION(r214572): Update fast/text/variations/advances.html to understand normalized variation widths
     4        https://bugs.webkit.org/show_bug.cgi?id=171356
     5        <rdar://problem/28670085>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Unspecified 'wdth' axis values are being normalized because the font is a GX font. However, this
     10        font assumes no normalization, which means one of the comparisons in the test is bogus.
     11
     12        * fast/text/variations/advances-expected.txt:
     13        * fast/text/variations/advances.html:
     14        * platform/ios/TestExpectations:
     15        * platform/mac/TestExpectations:
     16
    1172017-04-27  Antti Koivisto  <antti@apple.com>
    218

  • trunk/LayoutTests/fast/text/variations/advances-expected.txt

    r206896 r215884  
    1 PASS regular.offsetWidth is not wide.offsetWidth
    2 PASS regular.offsetWidth is not narrow.offsetWidth
     1PASS specifiedregular.offsetWidth is not wide.offsetWidth
     2PASS specifiedregular.offsetWidth is not narrow.offsetWidth
    33PASS narrow.offsetWidth is not wide.offsetWidth
    4 PASS regular.offsetWidth is specifiedregular.offsetWidth
    54PASS successfullyParsed is true
    65

  • trunk/LayoutTests/fast/text/variations/advances.html

    r211060 r215884  
    3030        var narrow = document.getElementById("narrow");
    3131
    32         shouldNotBe("regular.offsetWidth", "wide.offsetWidth");
    33         shouldNotBe("regular.offsetWidth", "narrow.offsetWidth");
     32        shouldNotBe("specifiedregular.offsetWidth", "wide.offsetWidth");
     33        shouldNotBe("specifiedregular.offsetWidth", "narrow.offsetWidth");
    3434        shouldNotBe("narrow.offsetWidth", "wide.offsetWidth");
    35         shouldBe("regular.offsetWidth", "specifiedregular.offsetWidth");
    3635        finishJSTest();
    3736});

  • trunk/LayoutTests/platform/ios/TestExpectations

    r215874 r215884  
    27422742
    27432743# This variation font test requires Skia which isn't available on iOS.
    2744 webkit.org/b/163093 fast/text/variations/advances.html [ Failure ]
    27452744webkit.org/b/163093 fast/text/variations/outofbounds.html [ ImageOnlyFailure ]
    27462745webkit.org/b/163093 fast/text/variations/default-value.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r215849 r215884  
    15221522webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
    15231523
    1524 webkit.org/b/166672 [ Sierra+ ] fast/text/variations/advances.html [ Failure ]
    1525 
    15261524webkit.org/b/162507 http/tests/media/hls/hls-video-resize.html [ Pass Failure ]
    15271525
Note: See TracChangeset for help on using the changeset viewer.