Changeset 21641 in webkit

Timestamp:

May 22, 2007, 12:02:37 PM (18 years ago)

Author:

beidson

Message:

Reviewed by Kevin (Sarge)

<rdar://problem/5219885> - Crash after closing a inline popup ad at ​http://news.yahoo.com/

This regressed in ​http://trac.webkit.org/projects/webkit/changeset/21618

• WebView/WebFrame.mm: (-[WebFrame dataSource]): Null check the frameloader

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebFrame.mm (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-05-22  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Kevin (Sarge)
+
+        <rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/
+
+        This regressed in http://trac.webkit.org/projects/webkit/changeset/21618
+
+        * WebView/WebFrame.mm:
+        (-[WebFrame dataSource]): Null check the frameloader
+
 2007-05-21  Adele Peterson  <adele@apple.com>
 

trunk/WebKit/WebView/WebFrame.mm

@@ -776 +776 @@
 - (WebDataSource *)dataSource
 {
-    if (![self _frameLoader]->frameHasLoaded())
+    FrameLoader* loader = [self _frameLoader];
+    if (!loader || !loader->frameHasLoaded())
         return nil;