Changeset 21646 in webkit


Ignore:
Timestamp:
May 22, 2007 3:59:02 PM (17 years ago)
Author:
darin
Message:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear

The contentWindow property was doing a cross-frame security check, but it shouldn't.
Window objects are responsible for protecting themselves from cross-frame activity.
Because contentWindow returned undefined, we then ended up setting visibility on the
body of the main frame to "hidden".

No layout test yet. When we make cross-domain tests, we should include this one.

  • html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
  • html/HTMLIFrameElement.idl: Ditto.
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r21642 r21646  
     12007-05-22  Darin Adler  <darin@apple.com>
     2
     3        Reviewed by Tim Hatcher.
     4
     5        - fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories"
     6          tab makes page content disappear
     7
     8        The contentWindow property was doing a cross-frame security check, but it shouldn't.
     9        Window objects are responsible for protecting themselves from cross-frame activity.
     10        Because contentWindow returned undefined, we then ended up setting visibility on the
     11        body of the main frame to "hidden".
     12
     13        No layout test yet. When we make cross-domain tests, we should include this one.
     14
     15        * html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
     16        * html/HTMLIFrameElement.idl: Ditto.
     17
    1182007-05-22  Justin Garcia  <justin.garcia@apple.com>
    219

  • trunk/WebCore/html/HTMLFrameElement.idl

    r21624 r21646  
    3838#if defined(LANGUAGE_JAVASCRIPT)
    3939        // FIXME: this need not be JS only. See http://bugs.webkit.org/show_bug.cgi?id=13798
    40         readonly attribute [CheckFrameSecurity] Window          contentWindow;
     40        readonly attribute Window contentWindow;
    4141#endif
    4242

  • trunk/WebCore/html/HTMLIFrameElement.idl

    r21624 r21646  
    4040#if defined(LANGUAGE_JAVASCRIPT)
    4141        // FIXME: this need not be JS only. See http://bugs.webkit.org/show_bug.cgi?id=13798
    42         readonly attribute [CheckFrameSecurity] Window          contentWindow;
     42        readonly attribute Window contentWindow;
    4343#endif
    4444
Note: See TracChangeset for help on using the changeset viewer.