Changeset 216532 in webkit


Ignore:
Timestamp:
May 9, 2017 12:15:31 PM (7 years ago)
Author:
Matt Lewis
Message:

Unreviewed, rolling out r216508.

The layout test enabled in this change is failing on Sierra.

Reverted changeset:

"Invalid MediaSource duration value should throw TyperError
instead of InvalidStateError"
​https://bugs.webkit.org/show_bug.cgi?id=171653
​http://trac.webkit.org/changeset/216508

Location:
trunk
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r216529 r216532  
     12017-05-09  Matt Lewis  <jlewis3@apple.com>
     2
     3        Unreviewed, rolling out r216508.
     4
     5        The layout test enabled in this change is failing on Sierra.
     6
     7        Reverted changeset:
     8
     9        "Invalid MediaSource duration value should throw TyperError
     10        instead of InvalidStateError"
     11        https://bugs.webkit.org/show_bug.cgi?id=171653
     12        http://trac.webkit.org/changeset/216508
     13
    1142017-05-09  Matt Lewis  <jlewis3@apple.com>
    215

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r216508 r216532  
    251251webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-framerate.html [ Failure ]
    252252webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-framesize.html [ Failure ]
     253webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Failure ]
    253254webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Failure ]
    254255webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Failure ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r216508 r216532  
    10021002webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-appendbuffer-quota-exceeded.html [ Skip ]
    10031003webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html [ Skip ]
     1004webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions.html [ Skip ]
    10041005webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-endofstream.html [ Skip ]
    10051006webkit.org/b/161725 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-errors.html [ Skip ]

  • trunk/Source/WebCore/ChangeLog

    r216531 r216532  
     12017-05-09  Matt Lewis  <jlewis3@apple.com>
     2
     3        Unreviewed, rolling out r216508.
     4
     5        The layout test enabled in this change is failing on Sierra.
     6
     7        Reverted changeset:
     8
     9        "Invalid MediaSource duration value should throw TyperError
     10        instead of InvalidStateError"
     11        https://bugs.webkit.org/show_bug.cgi?id=171653
     12        http://trac.webkit.org/changeset/216508
     13
    1142017-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
    215

  • trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp

    r216509 r216532  
    464464{
    465465    // 2.1 Attributes - Duration
    466     // https://www.w3.org/TR/2016/REC-media-source-20161117/#attributes
     466    // https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#attributes
    467467
    468468    // On setting, run the following steps:
    469     // 1. If the value being set is negative or NaN then throw a TypeError exception and abort these steps.
     469    // 1. If the value being set is negative or NaN then throw an INVALID_ACCESS_ERR exception and abort these steps.
    470470    if (duration < 0.0 || std::isnan(duration))
    471         return Exception { TypeError };
    472 
    473     // 2. If the readyState attribute is not "open" then throw an InvalidStateError exception and abort these steps.
     471        return Exception { INVALID_ACCESS_ERR };
     472
     473    // 2. If the readyState attribute is not "open" then throw an INVALID_STATE_ERR exception and abort these steps.
    474474    if (!isOpen())
    475475        return Exception { INVALID_STATE_ERR };
    476476
    477     // 3. If the updating attribute equals true on any SourceBuffer in sourceBuffers, then throw an InvalidStateError
     477    // 3. If the updating attribute equals true on any SourceBuffer in sourceBuffers, then throw an INVALID_STATE_ERR
    478478    // exception and abort these steps.
    479479    for (auto& sourceBuffer : *m_sourceBuffers) {
    … …  
    489489{
    490490    // 2.4.6 Duration Change
    491     // https://www.w3.org/TR/2016/REC-media-source-20161117/#duration-change-algorithm
     491    // https://rawgit.com/w3c/media-source/45627646344eea0170dd1cbc5a3d508ca751abb8/media-source-respec.html#duration-change-algorithm
    492492
    493493    MediaTime newDuration = duration;
Note: See TracChangeset for help on using the changeset viewer.